Bug: Can't change user group members

[DanHammond]

Page: project/{id}/environment/{id}/organisation-settings
Suspected reproduction steps:

• Create a user
• Add them to a group
• Delete the user
• Create another user
• Try add this user to the group

Outcome:

• Fails to add user
• Shows wrong count of users for the group (still including deleted user)

API response:
400. User {id} does not exist in this organisation

Note:
Looks like it's still trying to post back the id for the deleted user

[dabeeeenster]

Thanks for the raised issue; we'll take a look.

[kyle-ssg]

I have replicated this issue and confirm the following:

If a user belonging to a group is deleted from the organisation, the api does not update groups for that organisation. Even after refreshing, deleted users still belong to groups, which causes an error when attempting to update anything to do with the group.

Simplest replication:

• create a group with 2 members
• delete one of the members from the organisation
• attempt to re-save the group

Even after refreshing the browser, the user is unable to save the group.

[milanjaros]

Confirming bug on both on-prem v2.7.3 and cloud.

POST https://api.flagsmith.com/api/v1/organisations/1213/groups/165/add-users/

{"user_ids":[1268]}

results in

HTTP 400 Bad Request
{"detail":"User 1268 does not exist in this organisation"}

Workaround:

1. Create a new group with the same users
2. Set proper Permissions to the new group in Project Settings
3. Delete the old group

To prevent this, remove a user from all groups before you delete him.