Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: Remove sanity checks and change full suite IT OS to macOS #1439

Merged
merged 2 commits into from Dec 31, 2020
Merged

ci: Remove sanity checks and change full suite IT OS to macOS #1439

merged 2 commits into from Dec 31, 2020

Conversation

piotradamczyk5
Copy link
Contributor

@piotradamczyk5 piotradamczyk5 commented Dec 31, 2020 •
edited

  1. The old integration tests are not needed anymore because we have daily/comment/manual trigger for full suite. They just consume our quote, so they were removed
  2. Full suite integration tests will use macos-latest instead of ubuntu-latest to prevent occurring issue with sharding performance

Test Plan

How do we know the code works?

IT works as previous

Checklist

  • Full suite IT OS changed from Ubuntu to MacOS
  • Sanity check removed

@piotradamczyk5 piotradamczyk5 self-assigned this Dec 31, 2020
@piotradamczyk5 piotradamczyk5 enabled auto-merge (squash) December 31, 2020 09:52
@piotradamczyk5 piotradamczyk5 changed the title ci: Remove sanity checks and change os to macOS ci: Remove sanity checks and change full suite IT OS to macOS Dec 31, 2020
@github-actions
Copy link
Contributor

github-actions bot commented Dec 31, 2020 •
edited

Timestamp: 2020-12-31 12:58:33
Buildscan url for ubuntu-workflow run 454529835
https://gradle.com/s/kvciwcirnnhx4

Sloox
Sloox approved these changes Dec 31, 2020
View reviewed changes
Copy link
Contributor

@Sloox Sloox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me.
For that sharding issue can we not just increase the time for sharding if its linux or something similar? @piotradamczyk5

adamfilipow92
adamfilipow92 approved these changes Dec 31, 2020
View reviewed changes
Copy link
Contributor

@adamfilipow92 adamfilipow92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@piotradamczyk5
Copy link
Contributor Author

Looks fine to me.
For that sharding issue can we not just increase the time for sharding if its linux or something similar? @piotradamczyk5

I am thinking about adding retry when CI==true

@piotradamczyk5 piotradamczyk5 merged commit 73a3c92 into master Dec 31, 2020
@piotradamczyk5 piotradamczyk5 deleted the it_improvements branch December 31, 2020 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sloox Sloox Sloox approved these changes

@adamfilipow92 adamfilipow92 adamfilipow92 approved these changes

@bootstraponline bootstraponline Awaiting requested review from bootstraponline

@zuziakaxel zuziakaxel Awaiting requested review from zuziakaxel

@pawelpasterz pawelpasterz Awaiting requested review from pawelpasterz

@jan-goral jan-goral Awaiting requested review from jan-goral

Assignees

@piotradamczyk5 piotradamczyk5

Labels
Snake 🐍
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@piotradamczyk5 @Sloox @adamfilipow92