Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

style: Add Kotlin Lint to tests #1515

Merged
merged 1 commit into from Jan 20, 2021
Merged

style: Add Kotlin Lint to tests #1515

merged 1 commit into from Jan 20, 2021

Conversation

piotradamczyk5
Copy link
Contributor

Test Plan

How do we know the code works?

Kt lint is enabled also for tests

@piotradamczyk5 piotradamczyk5 self-assigned this Jan 20, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Jan 20, 2021 •
edited

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

Sloox
Sloox approved these changes Jan 20, 2021
View reviewed changes
Copy link
Contributor

@Sloox Sloox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

adamfilipow92
adamfilipow92 approved these changes Jan 20, 2021
View reviewed changes
Copy link
Contributor

@adamfilipow92 adamfilipow92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@mergify mergify bot merged commit 88b6c52 into master Jan 20, 2021
@mergify mergify bot deleted the kotlin_lint_for_tests branch January 20, 2021 16:51
@github-actions
Copy link
Contributor

Timestamp: 2021-01-20 16:51:39
Buildscan url for ubuntu-workflow run 499069391
https://gradle.com/s/emfevmeyujph2

@github-actions github-actions bot locked and limited conversation to collaborators Jan 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Sloox Sloox Sloox approved these changes

@adamfilipow92 adamfilipow92 adamfilipow92 approved these changes

@bootstraponline bootstraponline Awaiting requested review from bootstraponline

@zuziakaxel zuziakaxel Awaiting requested review from zuziakaxel

@pawelpasterz pawelpasterz Awaiting requested review from pawelpasterz

@jan-goral jan-goral Awaiting requested review from jan-goral

Assignees

@piotradamczyk5 piotradamczyk5

Labels
Snake 🐍
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@piotradamczyk5 @Sloox @adamfilipow92