Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Add removing stack traces for simple report #1931

Merged
merged 2 commits into from May 14, 2021
Merged

refactor: Add removing stack traces for simple report #1931

merged 2 commits into from May 14, 2021

Conversation

piotradamczyk5
Copy link
Contributor

@piotradamczyk5 piotradamczyk5 commented May 13, 2021 •
edited

Test Plan

How do we know the code works?

Simple JunitReport does not contain stack traces for flaky tests

Checklist

  • Unit tested

@piotradamczyk5 piotradamczyk5 self-assigned this May 13, 2021
@github-actions
Copy link
Contributor

github-actions bot commented May 13, 2021 •
edited

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@github-actions
Copy link
Contributor

github-actions bot commented May 13, 2021 •
edited

Timestamp: 2021-05-13 18:45:23
Buildscan url for ubuntu-workflow run 839836570
https://gradle.com/s/eqdxa7vvijbig

@piotradamczyk5 piotradamczyk5 marked this pull request as ready for review May 13, 2021 12:08
@piotradamczyk5 piotradamczyk5 enabled auto-merge (squash) May 13, 2021 12:33
@bootstraponline bootstraponline force-pushed the junit_stack_trace branch 3 times, most recently from f02f569 to b98f3a9 Compare May 13, 2021 18:30
@piotradamczyk5
Copy link
Contributor Author

@flank-it

@github-actions
Copy link
Contributor

github-actions bot commented May 14, 2021 •
edited

Integration tests succeed for all OSes ✅
Windows Build scan:
MacOS Build scan: https://gradle.com/s/5znsbuc3iu2ho
Linux Build scan: https://gradle.com/s/hjt6xunrwrrzs
Workflow run https://github.com/Flank/flank/actions/runs/841163671

@piotradamczyk5 piotradamczyk5 merged commit c924773 into master May 14, 2021
@piotradamczyk5 piotradamczyk5 deleted the junit_stack_trace branch May 14, 2021 07:47
@github-actions github-actions bot locked and limited conversation to collaborators May 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Sloox Sloox Sloox approved these changes

@pawelpasterz pawelpasterz pawelpasterz approved these changes

@adamfilipow92 adamfilipow92 Awaiting requested review from adamfilipow92

@zuziakaxel zuziakaxel Awaiting requested review from zuziakaxel

@bootstraponline bootstraponline Awaiting requested review from bootstraponline

@jan-goral jan-goral Awaiting requested review from jan-goral

Assignees

@piotradamczyk5 piotradamczyk5

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@piotradamczyk5 @Sloox @pawelpasterz