build: update kotlin to 1.5.10 and remove warnings

[piotradamczyk5]

Fixes #1962

Test Plan

How do we know the code works?

Code compiles without any problem, there should not be any errors and warnings

[github-actions]

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

[github-actions]

Timestamp: 2021-05-25 10:16:14
Buildscan url for ubuntu-workflow run 874488867

[pawelpasterz]

@flank-it

[github-actions]

Integration tests failed ❌
Windows status failure - Build scan:
MacOS status failure - Build scan:
Linux status failure - Build scan: https://gradle.com/s/dmxlswnmz7gm2
Workflow run https://github.com/Flank/flank/actions/runs/873571454

[pawelpasterz]

Answering #1926 (comment)
Looks like it's working, there are couple of warnings left https://github.com/Flank/flank/pull/1965/checks?check_run_id=2658359081#step:7:383
Should we add implementation(...) to all those modules?

Let's also verify shadow jar size after all is fixed

[piotradamczyk5]

Answering #1926 (comment)
Looks like it's working, there are couple of warnings left https://github.com/Flank/flank/pull/1965/checks?check_run_id=2658359081#step:7:383
...
Let's also verify shadow jar size after all is fixed

I would fix #1926 in separate task (#1926 😄 ) because there could be also new warnings and as you mention we must validate fat jar size.

Should we add implementation(...) to all those modules?

I am not sure, this is one of the possible resolution. In flank we force libraries to use reflect with the same version as kotlin one, but I am not sure if this works

[piotradamczyk5]

Integration tests failed ❌
Windows status failure - Build scan:
MacOS status failure - Build scan:
Linux status failure - Build scan: https://gradle.com/s/dmxlswnmz7gm2
Workflow run https://github.com/Flank/flank/actions/runs/873571454

Quota...

[piotradamczyk5]

For curios developers, this caused build errors (missing explicit type)

[pawelpasterz]

Answering #1926 (comment)
Looks like it's working, there are couple of warnings left https://github.com/Flank/flank/pull/1965/checks?check_run_id=2658359081#step:7:383
...
Let's also verify shadow jar size after all is fixed

I would fix #1926 in separate task (#1926 😄 ) because there could be also new warnings and as you mention we must validate fat jar size.

Makes sense. Thanks!

Should we add implementation(...) to all those modules?

I am not sure, this is one of the possible resolution. In flank we force libraries to use reflect with the same version as kotlin one, but I am not sure if this works

👍🏻

[pawelpasterz]

@flank-it

[github-actions]

Integration tests succeed for all OSes ✅
Windows Build scan:
MacOS Build scan: https://gradle.com/s/ovc27kdwacup2
Linux Build scan: https://gradle.com/s/pftzvd4ohax5q
Workflow run https://github.com/Flank/flank/actions/runs/874353871