fix: Fix calculating total test cost in Mixpanel #2084
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamfilipow92
changed the title
adamfilipow92
changed the title
|
Timestamp: 2021-07-12 11:14:40 |
bootstraponline
force-pushed
the
fix-mixpanel-total-cost-reporting
branch
from
252b18b
to
ab069f2
Compare
piotradamczyk5
approved these changes
Jul 12, 2021
Sloox
approved these changes
Jul 12, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #
Test Plan
In mixpanel
devices_cost. total_costevent should be the sum of virtual cost and physical cost instead of the sum of physical and virtual minutes