Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Bash command execution #2127

Merged
merged 1 commit into from Aug 9, 2021
Merged

refactor: Bash command execution #2127

merged 1 commit into from Aug 9, 2021

Conversation

piotradamczyk5
Copy link
Contributor

@piotradamczyk5 piotradamczyk5 commented Aug 9, 2021 •
edited

Fixes #1770

Test Plan

How do we know the code works?

Code is refactored according to #1770. All commands works as previously

@piotradamczyk5 piotradamczyk5 marked this pull request as draft August 9, 2021 06:17
@github-actions
Copy link
Contributor

github-actions bot commented Aug 9, 2021 •
edited

Timestamp: 2021-08-09 07:52:15
Buildscan url for ubuntu-workflow run 1112027636
https://gradle.com/s/6yfwq5urqbwi2

@Sloox
Copy link
Contributor

Sloox commented Aug 9, 2021

@flank-it

@github-actions
Copy link
Contributor

github-actions bot commented Aug 9, 2021 •
edited

Integration tests succeed for all OSs ✅
Windows Build scan:
MacOS Build scan: https://gradle.com/s/jg7ovcxpj4loe
Linux Build scan: https://gradle.com/s/7by5bnmmguuvy
Workflow run https://github.com/Flank/flank/actions/runs/1111908702

@piotradamczyk5 piotradamczyk5 marked this pull request as ready for review August 9, 2021 07:20
Sloox
Sloox approved these changes Aug 9, 2021
View reviewed changes
Copy link
Contributor

@Sloox Sloox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍

@mergify mergify bot merged commit 72a8cd1 into master Aug 9, 2021
@mergify mergify bot deleted the 1770_bash_refactor branch August 9, 2021 14:03
@github-actions github-actions bot locked and limited conversation to collaborators Aug 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Sloox Sloox Sloox approved these changes

@pawelpasterz pawelpasterz pawelpasterz approved these changes

@jan-goral jan-goral Awaiting requested review from jan-goral

@adamfilipow92 adamfilipow92 Awaiting requested review from adamfilipow92

@zuziakaxel zuziakaxel Awaiting requested review from zuziakaxel

Assignees

@piotradamczyk5 piotradamczyk5

Labels
Feature Tiger 🐯
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Refactor Bash/Shell Environment
3 participants
@piotradamczyk5 @Sloox @pawelpasterz