Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Merging results for non legacy Android run #2151

Merged
merged 2 commits into from Aug 25, 2021

Conversation

piotradamczyk5
Copy link
Contributor

@piotradamczyk5 piotradamczyk5 commented Aug 24, 2021

Fixes #2143

Test Plan

How do we know the code works?

Results are merged properly as per discussion.

  1. Run flank with flank-multiple-success.yml config
  2. Check that JUnitReport.xml has grouped testsuite node by name

Before:

<?xml version='1.0' encoding='UTF-8' ?>
<testsuites>
  <testsuite name="NexusLowRes-28-en-portrait" tests="8" failures="0" flakes="0" errors="0" skipped="0" time="3.364" timestamp="2021-08-24T20:39:40" hostname="localhost">
    ...
  </testsuite>
  <testsuite name="NexusLowRes-28-en-portrait" tests="12" failures="0" flakes="0" errors="0" skipped="0" time="3.853" timestamp="2021-08-24T20:39:40" hostname="localhost">
    ...
  </testsuite>
  <testsuite name="junit-ignored" tests="4" failures="0" errors="0" skipped="4" time="0.0" timestamp="2021-08-24T20:40:30" hostname="localhost">
    ...
  </testsuite>
</testsuites>

After:

<?xml version='1.0' encoding='UTF-8' ?>
<testsuites>
  <testsuite name="NexusLowRes-28-en-portrait#" tests="20" failures="0" errors="0" skipped="0" time="6.894" timestamp="2021-08-24T20:47:28" hostname="localhost">
    ...
  </testsuite>
  <testsuite name="junit-ignored" tests="4" failures="0" errors="0" skipped="4" time="0.0" timestamp="2021-08-24T20:48:17" hostname="localhost">
  ...
  </testsuite>
</testsuites>

Checklist

  • Documented
  • Unit tested
  • Integration tests updated

@github-actions
Copy link
Contributor

github-actions bot commented Aug 24, 2021

Timestamp: 2021-08-25 19:47:44
Buildscan url for ubuntu-workflow run 1167863785
https://gradle.com/s/rr6vnucjeon2k

@piotradamczyk5
Copy link
Contributor Author

@flank-it

@github-actions
Copy link
Contributor

github-actions bot commented Aug 25, 2021

Integration tests failed ❌
Windows status failure - Build scan:
MacOS status failure - Build scan: https://gradle.com/s/7ucpmovc6w5tc
Linux status failure - Build scan: https://gradle.com/s/woupztzjhoavu
Workflow run https://github.com/Flank/flank/actions/runs/1165689419

Copy link
Contributor

@Sloox Sloox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks fine to me 🚀

@piotradamczyk5 piotradamczyk5 marked this pull request as ready for review August 25, 2021 19:38
@piotradamczyk5
Copy link
Contributor Author

@flank-it

@github-actions
Copy link
Contributor

Integration tests were triggered at 2021-08-25 19:39:55, you can track progress here

@mergify mergify bot merged commit bfe8d54 into master Aug 25, 2021
@mergify mergify bot deleted the 2143_mergeresult_android branch August 25, 2021 19:50
@github-actions github-actions bot locked and limited conversation to collaborators Aug 25, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update parsing for new Android XML changes
3 participants