Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Fix flaky flag #2156

Merged
merged 1 commit into from Aug 30, 2021
Merged

fix: Fix flaky flag #2156

merged 1 commit into from Aug 30, 2021

Conversation

pawelpasterz
Copy link
Contributor

Fixes #2145

Test Plan

How do we know the code works?

  1. run ./gradlew flankFullRun
  2. build finish normally
  3. start flank run with flaky tests
  4. observe the flaky flag being added to the flaky cases (previously missing)

Checklist

  • Unit tested

@pawelpasterz pawelpasterz self-assigned this Aug 29, 2021
@pawelpasterz pawelpasterz enabled auto-merge (squash) August 29, 2021 21:34
@pawelpasterz
Copy link
Contributor Author

@flank-it

@github-actions
Copy link
Contributor

github-actions bot commented Aug 29, 2021 •
edited

Integration tests succeed for all OSs ✅
Windows Build scan:
MacOS Build scan: https://gradle.com/s/br2rjtz6csc2g
Linux Build scan: https://gradle.com/s/as4jn5iaw4mhs
Workflow run https://github.com/Flank/flank/actions/runs/1180134381

@github-actions
Copy link
Contributor

github-actions bot commented Aug 29, 2021 •
edited

Timestamp: 2021-08-30 07:50:28
Buildscan url for ubuntu-workflow run 1181329294
https://gradle.com/s/2s7bo2puklzq6

@Sloox Sloox self-requested a review August 30, 2021 07:21
@pawelpasterz pawelpasterz merged commit d6ca49f into master Aug 30, 2021
@pawelpasterz pawelpasterz deleted the 2145-fix-flaky-flag branch August 30, 2021 15:37
@github-actions github-actions bot locked and limited conversation to collaborators Aug 30, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Sloox Sloox Sloox approved these changes

@piotradamczyk5 piotradamczyk5 piotradamczyk5 approved these changes

Assignees

@pawelpasterz pawelpasterz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Verify flaky="true" is correctly persisted in the Flank XML
3 participants
@pawelpasterz @Sloox @piotradamczyk5