Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support HTTP proxies with credentials. #2176

Merged
merged 4 commits into from
Nov 5, 2021

Conversation

jdm-square
Copy link
Contributor

Fixes #2175. The addition of the Jboss logging dependency is required to avoid a missing class exception when the HTTP transport is created; it bridges the logback instance to the logging in use inside of the network-related code.

This implementation is based off of the model code in https://github.com/googleapis/google-auth-library-java#configuring-a-proxy.

Test Plan

How do we know the code works?

Following the steps described in #2175, I have validated that flank behaves the same when mitmproxy requires credentials as when it does not.

Checklist

  • Documented (I don't know where this should be documented)
  • Unit tested (I have no idea how this is possible)
  • Integration tests updated (I don't think this is relevant?)

@github-actions
Copy link
Contributor

github-actions bot commented Nov 4, 2021

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@mergify
Copy link

mergify bot commented Nov 4, 2021

Title does not follow the guidelines of Conventional Commits.
Please adjust title before merge and use one of following prefix:

  • build - Changes that affect the build system or external dependencies (dependencies update)
  • ci - Changes to our CI configuration files and scripts (basically directory .github/workflows)
  • docs - Documentation only changes
  • feat - A new feature
  • fix - A bug fix
  • chore - Changes which does not touch the code (ex. manual update of release notes). It will not generate release notes changes
  • refactor - A code change that contains refactor
  • style - Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
  • test - Adding missing tests or correcting existing tests and also changes for our test app
  • perf - A code change that improves performance (I do not think we will use it)

1 similar comment
@mergify
Copy link

mergify bot commented Nov 4, 2021

Title does not follow the guidelines of Conventional Commits.
Please adjust title before merge and use one of following prefix:

  • build - Changes that affect the build system or external dependencies (dependencies update)
  • ci - Changes to our CI configuration files and scripts (basically directory .github/workflows)
  • docs - Documentation only changes
  • feat - A new feature
  • fix - A bug fix
  • chore - Changes which does not touch the code (ex. manual update of release notes). It will not generate release notes changes
  • refactor - A code change that contains refactor
  • style - Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
  • test - Adding missing tests or correcting existing tests and also changes for our test app
  • perf - A code change that improves performance (I do not think we will use it)

@jdm-square jdm-square changed the title Support HTTP proxies with credentials. feat: Support HTTP proxies with credentials. Nov 4, 2021
@jdm-square
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

@bootstraponline
Copy link
Contributor

Thanks for the contribution!

Please add a FAQ entry to https://github.com/Flank/flank/blob/master/docs/index.md that explains how to run Flank with a proxy. After that I'll merge. The code looks good.

@bootstraponline bootstraponline merged commit 0e8d226 into Flank:master Nov 5, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Nov 5, 2021
@bootstraponline
Copy link
Contributor

I found the command in the linked issue. The snapshot jar will auto update once the build passes on master.

I'll make a new stable release next week.

@bootstraponline
Copy link
Contributor

https://github.com/Flank/flank/releases/tag/flank-snapshot has been updated with the feature.

@bootstraponline
Copy link
Contributor

@jdm-square stable release has been published. https://github.com/Flank/flank/releases/tag/v21.11.0

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't use HTTP proxies requiring credentials
2 participants