Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Remove usage of secrets to fix failing builds #2369

Merged
merged 1 commit into from May 2, 2023

Conversation

rfogar2
Copy link
Contributor

@rfogar2 rfogar2 commented May 2, 2023

Fixes #

Illegal use of secrets, see comment in this PR for more context

#2360

I'm working on a way to resolve the original issue (rate-limiting) without breaking things, but this pull request will at least fix the new problem in the meantime.

Test Plan

How do we know the code works?

.

Checklist

  • Documented
  • Unit tested
  • Integration tests updated

@rfogar2
Copy link
Contributor Author

rfogar2 commented May 2, 2023

@Fry-kun can you approve and merge this? I'm aware this will be breaking things for a lot of people.

@adamvduke
Copy link
Contributor

Seems like this partial rollback of #2360 should be safe, because there is a guard against adding the token to the request if it's blank, and it wasn't being passed previously.

fun Request.appendGitHubHeaders(githubToken: String, contentType: String = "application/vnd.github.v3+json") =
appendHeader("Accept", contentType).also {
if (githubToken.isNotBlank())
appendHeader("Authorization", "token $githubToken")
}

@adamvduke adamvduke changed the title Remove usage of secrets to fix failing builds fix: Remove usage of secrets to fix failing builds May 2, 2023
@adamvduke adamvduke merged commit ee8b463 into Flank:master May 2, 2023
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants