Switch to jqeventrouter for routing #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- The main routing functionality is moved to github.com/flimzy/eventrouter
- App-specific functionality is being moved to webclient/controllers
* Stop passing around x/net/context.
- Most of what that provides (per-request context) isn't relevant in an
SPA, and it makes things messy
- Instead, I've made certain sub-modules more stateful. This may need
revisiting, especially to allow for tests.
* Moved some cordova logic to github.com/flimzy/go-cordova. If/how this
module will exist in the future is a question.
* Add some General-purpose handlers: - One to strip #_=_ from Facebook redirect urls - One to ensure jQM events are only routed once * Get rid of the 'state' module for now, just fall back to reading the cookie every time to see if a user is logged in
And properly clean up #_=_ in address bar
flimzy
added a commit
that referenced
this pull request
Feb 10, 2016
Switch to jqeventrouter for routing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This simplifies logic, by getting rid of my horrendously complex routing, and using a more idiomatic approach, based on net/http routing methods.