Providing type hints for IDEs and linters #140
Labels
Comments
|
I agree - but I think it's best to wait until we drop 2.7 support so we don't have to use the 'comment' style type hints. Up to now - both flask and werkzeug are continuing to issue new feature releases that are still compatible with 2.7 |
|
Though to be fair the user base of this package is probably not using Python 2.7, so keeping Python 2.7 until the end of the year will probably save no-one. If it saves development time that could be used elsewhere I'd say it's worth it. |
jwag956
added a commit
that referenced
this issue
Jul 11, 2021
This adds types to the Security constructor and init_app. This required major refactoring of how initialization happened since prior to this
all arguments were added to kwargs (including default forms, config variables, etc) then set as attributes on the instance. Not easy to provide types for each one.
We remove all that, remove the _SecurityState class and concept.
Furthermore - in many places - we change from using _securyty.attr and use config_value("xxx").
Improve performance of config_value - no reason to create a dictonary every time - just query the key!
Add typing to more tests and views to help verify the types make sense.
Fix view responses - the types should be flask.ResponsValue - not Response
Fix 'within' and 'grace' typing - then can take floats.
closes: #140
Merged
jwag956
added a commit
that referenced
this issue
Jul 11, 2021
This adds types to the Security constructor and init_app. This required major refactoring of how initialization happened since prior to this
all arguments were added to kwargs (including default forms, config variables, etc) then set as attributes on the instance. Not easy to provide types for each one.
We remove all that, remove the _SecurityState class and concept.
Furthermore - in many places - we change from using _securyty.attr and use config_value("xxx").
Improve performance of config_value - no reason to create a dictonary every time - just query the key!
Add typing to more tests and views to help verify the types make sense.
Fix view responses - the types should be flask.ResponsValue - not Response
Fix 'within' and 'grace' typing - then can take floats.
closes: #140
jwag956
added a commit
that referenced
this issue
Jul 11, 2021
This adds types to the Security constructor and init_app. This required major refactoring of how initialization happened since prior to this
all arguments were added to kwargs (including default forms, config variables, etc) then set as attributes on the instance. Not easy to provide types for each one.
We remove all that, remove the _SecurityState class and concept.
Furthermore - in many places - we change from using _securyty.attr and use config_value("xxx").
Improve performance of config_value - no reason to create a dictonary every time - just query the key!
Add typing to more tests and views to help verify the types make sense.
Fix view responses - the types should be flask.ResponsValue - not Response
Fix 'within' and 'grace' typing - then can take floats.
closes: #140
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
It would be really nice if code could slowly start utilizing Python's type hints as specified by this PEP to possibly catch a few bugs but just to simplify development when using a good IDE.
The text was updated successfully, but these errors were encountered: