Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve oauth debugging #912

Closed
jwag956 opened this issue Jan 31, 2024 · 0 comments · Fixed by #915
Closed

Improve oauth debugging #912

jwag956 opened this issue Jan 31, 2024 · 0 comments · Fixed by #915
Assignees
@jwag956
Labels
enhancement
Milestone
5.4

Comments

@jwag956
Copy link
Member

jwag956 commented Jan 31, 2024

Lots of things can go wrong with oauth - especially for developers trying to get configuration correct.
RIght now - if oauthglue::oauthresponse gets an error when calling authlib to parse the response - we basically just redirect to /login - which is fine - but doesn't help developers.

easy improvement - add a signal so app developers can see/log errors.
@jwag956 jwag956 added this to the 5.4 milestone Jan 31, 2024
@jwag956 jwag956 self-assigned this Feb 2, 2024
jwag956 added a commit that referenced this issue Feb 4, 2024
@jwag956
Improve oauth glue
d4ffca0 
Some providers e.g. Azure require the redirect URL to match exactly - including query params etc. To support that
we now store any 'next' value in the session (fs_oauth_next).

To enable better debugging a class that can be subclassed for each provider - the auth_response_error() method can be subclassed for better debugging/UX.

Convert our Github and Google pre-defined providers to the new class method.

Add support for Azure in the Oauth example code.

Change OAUTH_HANDSHAKE_ERROR to include info from authlib.

closes #912
jwag956 added a commit that referenced this issue Feb 4, 2024
@jwag956
Improve oauth glue
8fcb908 
Some providers e.g. Azure require the redirect URL to match exactly - including query params etc. To support that
we now store any 'next' value in the session (fs_oauth_next).

To enable better debugging a class that can be subclassed for each provider - the auth_response_error() method can be subclassed for better debugging/UX.

Convert our Github and Google pre-defined providers to the new class method.

Add support for Azure in the Oauth example code.

Change OAUTH_HANDSHAKE_ERROR to include info from authlib.

closes #912
jwag956 added a commit that referenced this issue Feb 4, 2024
@jwag956
Improve oauth glue
4c68ed2 
Some providers e.g. Azure require the redirect URL to match exactly - including query params etc. To support that
we now store any 'next' value in the session (fs_oauth_next).

To enable better debugging a class that can be subclassed for each provider - the auth_response_error() method can be subclassed for better debugging/UX.

Convert our Github and Google pre-defined providers to the new class method.

Add support for Azure in the Oauth example code.

Change OAUTH_HANDSHAKE_ERROR to include info from authlib.

closes #912
@jwag956 jwag956 mentioned this issue Feb 4, 2024
Merged
jwag956 added a commit that referenced this issue Feb 4, 2024
@jwag956
Improve oauth glue
338448a 
Some providers e.g. Azure require the redirect URL to match exactly - including query params etc. To support that
we now store any 'next' value in the session (fs_oauth_next).

To enable better debugging a class that can be subclassed for each provider - the auth_response_error() method can be subclassed for better debugging/UX.

Convert our Github and Google pre-defined providers to the new class method.

Add support for Azure in the Oauth example code.

Change OAUTH_HANDSHAKE_ERROR to include info from authlib.

closes #912
jwag956 added a commit that referenced this issue Feb 4, 2024
@jwag956
Improve oauth glue
1b20447 
Some providers e.g. Azure require the redirect URL to match exactly - including query params etc. To support that
we now store any 'next' value in the session (fs_oauth_next).

To enable better debugging a class that can be subclassed for each provider - the auth_response_error() method can be subclassed for better debugging/UX.

Convert our Github and Google pre-defined providers to the new class method.

Add support for Azure in the Oauth example code.

Change OAUTH_HANDSHAKE_ERROR to include info from authlib.

closes #912
jwag956 added a commit that referenced this issue Feb 4, 2024
@jwag956
Improve oauth glue
4d42bae 
Some providers e.g. Azure require the redirect URL to match exactly - including query params etc. To support that
we now store any 'next' value in the session (fs_oauth_next).

To enable better debugging a class that can be subclassed for each provider - the auth_response_error() method can be subclassed for better debugging/UX.

Convert our Github and Google pre-defined providers to the new class method.

Add support for Azure in the Oauth example code.

Change OAUTH_HANDSHAKE_ERROR to include info from authlib.

closes #912
jwag956 added a commit that referenced this issue Feb 4, 2024
@jwag956
Improve oauth glue (#915)
0b971c1 
Some providers e.g. Azure require the redirect URL to match exactly - including query params etc. To support that
we now store any 'next' value in the session (fs_oauth_next).

To enable better debugging a class that can be subclassed for each provider - the auth_response_error() method can be subclassed for better debugging/UX.

Convert our Github and Google pre-defined providers to the new class method.

Add support for Azure in the Oauth example code.

Change OAUTH_HANDSHAKE_ERROR to include info from authlib.

closes #912
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jwag956 jwag956

Labels
enhancement
Projects
None yet
Milestone
5.4
Development

Successfully merging a pull request may close this issue.

Improve oauth glue Flask-Middleware/flask-security
1 participant
@jwag956