Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Completely change json error response #638

Merged
merged 1 commit into from Jul 22, 2022
Merged

Completely change json error response #638

merged 1 commit into from Jul 22, 2022

Conversation

jwag956
Copy link
Member

@jwag956 jwag956 commented Jul 20, 2022

Now return errors is always a simple list of errors.
we also return field_errors - which is the old wtforms dict of errors.

Support new wtforms 3.0 form level errors.

@codecov
Copy link

codecov bot commented Jul 20, 2022

Codecov Report

Merging #638 (1cbd618) into master (0bf4f8e) will decrease coverage by 0.01%.
The diff coverage is 96.42%.

@@            Coverage Diff             @@
##           master     #638      +/-   ##
==========================================
- Coverage   98.06%   98.04%   -0.02%     
==========================================
  Files          31       31              
  Lines        4338     4347       +9     
==========================================
+ Hits         4254     4262       +8     
- Misses         84       85       +1     
Impacted Files Coverage Δ
flask_security/utils.py 97.36% <93.75%> (-0.19%) ⬇️
flask_security/tf_plugin.py 99.22% <100.00%> (+<0.01%) ⬆️
flask_security/unified_signin.py 98.77% <100.00%> (ø)
flask_security/views.py 98.73% <100.00%> (+<0.01%) ⬆️
flask_security/webauthn.py 98.65% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0bf4f8e...1cbd618. Read the comment docs.

Now return errors is always a simple list of errors.
we also return field_errors - which is the old wtforms dict of errors.

Support new wtforms 3.0 form level errors.

Convert some view code to utilize form level errors.
@jwag956 jwag956 merged commit 693a084 into master Jul 22, 2022
@jwag956 jwag956 deleted the formerror branch July 22, 2022 01:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant