Improve support for 2FA and unified signin method localizations. #889
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #889 +/- ##
==========================================
- Coverage 98.33% 98.29% -0.05%
==========================================
Files 34 34
Lines 4453 4465 +12
==========================================
+ Hits 4379 4389 +10
- Misses 74 76 +2 ☔ View full report in Codecov by Sentry. |
Improve on recent PR that adds support for 2FA method translations - it didn't actually call a localize_callback to translate the data. Add tests to verify actual xlation is occurring. Remove support for Flask-BabelEx. Use Babel.format_lists to construct the list of existing setup unified signup methods - moving this from the template to the view. Fix view_scaffold localization configuration.
|
Great, thanks and sorry for the drawback. I will update translation strings accordingly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve on recent PR that adds support for 2FA method translations - it didn't actually call a localize_callback to translate the data.
Add tests to verify actual xlation is occurring.
Remove support for Flask-BabelEx.
Use Babel.format_lists to construct the list of existing setup unified signup methods - moving this from the template to the view.
Fix view_scaffold localization configuration.
@gissimo When I wrote some tests - I (re) learned that in Flask-Security '_' is just a marker for strings to translate - it doesn't actually do any translation - so minor change to fix that.
unified signin has very similar 'methods' - so combined that with what you did. Minor wording changes - let me know of any concerns.