Allow email validation errors to be returned even when GENERIC_RESPON… #961
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…SES is set to True. We need to be careful not to expose whether an account already exists - but syntax or other errors should be returned. This enables custom implementations of MailUtil to enforce their own conventions and return useful results to callers. closes #942
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #961 +/- ##
==========================================
- Coverage 98.47% 98.40% -0.07%
==========================================
Files 35 35
Lines 4513 4527 +14
==========================================
+ Hits 4444 4455 +11
- Misses 69 72 +3 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…SES is set to True.
We need to be careful not to expose whether an account already exists - but syntax or other errors should be returned. This enables custom implementations of MailUtil to enforce their own conventions and return useful results to callers.
closes #942