Update base.html #181
Closed
Update base.html #181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Do you need to load tailwind.min.css from the CDN if you're already including it in the assets? I am assuming that it was built to provide additional classes.
|
Well @ishwon i need to contact either sandeep or anyone who knows tailwind. I don't know what tree shaking both have, like we brute loaded the files, also some notus classes are not loading. So as we are not sure, we keep both until we can build it |
|
Noted. I might have a look at it this weekend. Been doing some Tailwind recently, that's why it triggered my interest when I saw that. I'll see what notus does and if I can help with that. |
|
@ishwon i am somewhat in the dark, great if you can sort this out! |
|
Feel free to close this PR as you progress! |
|
I made another PR with fix for the Tailwind duplication. Closing this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do you need to load tailwind.min.css from the CDN if you're already including it in the assets? I am assuming that it was built to provide additional classes.