Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implemented compound merge/sort/unique algorithm for optimization #12

Closed
wants to merge 26 commits into from
Closed

Implemented compound merge/sort/unique algorithm for optimization #12

wants to merge 26 commits into from

Conversation

Flast
Copy link
Owner

@Flast Flast commented Jul 22, 2021 •
edited

New algorithm does (stable) sort, unique, and inplace merge at once. It may reduce number of scanning count of range.

TODO:

  • Use other sort algorithm for smaller range instead of merge sort.
  • Performance benchmarking.
  • Reduce inplace_merge memory footprint (if possible)
  • Consider optimizations
  • Update documentation (mainly computation order)

@Flast Flast added the enhancement New feature or request label Jul 22, 2021
@Flast Flast force-pushed the inplace_unique_sort_merge branch from 3761ab9 to 9d62be8 Compare July 23, 2021 01:05
Flast added 21 commits July 23, 2021 11:29
@Flast
Desired range order as compile time variable
996c303
@Flast
Switch condition order for fusing loop condition
8696926
@Flast
Reduce condition evaluation count
46f62fd
@Flast
Added special functions to detect algorithm failure easier
407a0e3
@Flast
Implemented insertion sort
13c02ec
@Flast
Skip leading lesser sorted range
b5ee982
@Flast
Enabled clang 10 CI
5f8a9dd
@Flast
Specialize first two elements sort
1cc8084
@Flast
Always enable both implementations
1f897c2
@Flast
Removed unintended newline
2fca883
@Flast
Fixed a typo
3133fa3
@Flast
Fixed fallthrough warnings in GCC
c3caba4
@Flast
Fixed argument evaluation order
0ec9aa0
@Flast
Added tests for eval order bug
5ae21e9
@Flast
Removed extra semicolon
561a980
@Flast
Enable template parameter deduction
a16ec0d
@Flast
Updated insertion benchmark
c7a0c68
@Flast
Added benchmark for algorithms
337ca7d
@Flast
Removed unused local typedef
cf80704
@Flast
Fixed template arguments
cfff508
@Flast
Use upper_bound instead of reversed find_if
152920c
@Flast
Copy link
Owner Author

Flast commented Sep 4, 2021

It's not able to be faster than naive algorithm combination...

@Flast Flast closed this Sep 4, 2021
@Flast Flast deleted the inplace_unique_sort_merge branch September 4, 2021 06:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@Flast