New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bitshift bug in SRA #9
Comments
agustiza
added a commit
to agustiza/PicoBlaze_Simulator_in_JS
that referenced
this issue
Aug 21, 2023
FlatAssembler
added a commit
that referenced
this issue
Aug 21, 2023
fix: Fixes #9 SRA carry flag is set on the MSB instead of LSB
FlatAssembler
pushed a commit
that referenced
this issue
Oct 6, 2023
FlatAssembler
added a commit
that referenced
this issue
Oct 6, 2023
fix: Fixes #9 SRA carry flag is set on the MSB instead of LSB
FlatAssembler
added a commit
that referenced
this issue
Apr 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hi!
Thanks for sharing your project!
Just so you know it's being used as an educational tool as an intro for embedded devices in an Argentine college to great effect.
That said I couldn't help but notice a small bug. I'll push a quick PR if you don't mind.
Description
On the SRA instruction. This line specifically, seems it's shifting the carry flag to the right instead of to the left.
Here's the snippet of code that surfaced this bug. Swaps MSB and LSB using shifts and carry only
The text was updated successfully, but these errors were encountered: