Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Timeline editing issues #519

Closed
6 tasks done
mafiesto4 opened this issue May 13, 2021 · 10 comments
Closed
6 tasks done

Timeline editing issues #519

mafiesto4 opened this issue May 13, 2021 · 10 comments
Labels
bug Something isn't working editor

Comments

@mafiesto4
Copy link
Member

mafiesto4 commented May 13, 2021

Batched issues related to keyframes and curves editors used in animation timelines. Reported by @W2Wizard

  • 1) Zooming into the timeline (of a scene animation) doesn't really have a limit, editor starts to freakout when you keep doing it and is laggy (fix: 347eaa9 and 052366b).
    image

  • 2) The handle bars don't move accurately where the cursor is (fix: 9464c50).

TimlineBarIssue.mp4
  • 3) Weird grey box (probably a keyframe knob). To reproduce just make something with a Vec3, make some keyframes and select one of them.
GrayBoxOfDoom.mp4
  • 4) Clickable area for keyframes should be a bit bigger, right now you have to be pixel accurate.
TeeneTinyKeyframe.mp4
  • 5) The timeline view expandle would make it way more easier to see where your keyframes actually are (fix: bbe9193).

image

  • 6) Overall I personally prefer it way much when all of the keyframes are present in a single view instead, e.g UE4. Having it separate like that makes it imo harder to navigate. - we already have collapsed tracks with keyframes but it culd be improved for nested tracks + add ability to move keyframes from multiple tracks at once (rectangular selection). (added: d19d0ef)

image

@mafiesto4 mafiesto4 added bug Something isn't working editor labels May 13, 2021
@W2Wizard
Copy link
Contributor

W2Wizard commented May 14, 2021

  • 7) Another issue that I found is that overall the preview value gets really tiny and unreadable for Vec3 for instance once you reach 3 digit values: (fix: 9012397)

image

@W2Wizard
Copy link
Contributor

W2Wizard commented May 14, 2021

  • 8) When having a nested timeline in you can add a reference to the same asset itself, when you do that, the editor freezes. (fix: 25487c1)

After that your timeline is useless:
image

Can't add or do anything anymore.

@W2Wizard
Copy link
Contributor

W2Wizard commented May 14, 2021

  • 9) When the camera track gets too small you get this (fix: 080b3b1):

image

@W2Wizard
Copy link
Contributor

W2Wizard commented May 14, 2021

  • 10) Not even sure whats happening here, but the norm is usually:
    Scroll wheel -> move up and down
    CTRL + Wheel -> Zoom in and out

It seems for nested timelines this does not really work? Atleast for me that is, also the values seem to be really precise which the zoom in and out should avoid but it doesn't work. It just results in a really slow scrolling. (In the video thats when I suddenly stop and just move up and down a little bit)

ScrollingOfDoom.mp4

@W2Wizard
Copy link
Contributor

W2Wizard commented May 14, 2021

KeyframeOfDoom.mp4

@honzapatCZ
Copy link
Contributor

honzapatCZ commented Jul 17, 2021

  • 12) Multi track box selection(Why shouldnt I be able to select keyframes on mulitple tracks (fix: 0063ec3) and move them at once (fix: b85521d))
  • 13) Scaling is completely fucked up - ie if you move out of the default scale, the keyframes do not move -> results in desynchronization (has been improved recently)
  • 14) Copy pasting - should be possible in same types, even cross track (added: 0d5fa3e)
  • 15) Bigger areas for selection(both moving(especially reordering tracks) and selecting(ie trying to select a keyframe)) - fix: aa75a2a
  • 16) Creating new keyframe at point where one already is should replace previous keyframe
  • 17) Editor preview - the current is weird - you have to be in play mode, save asset, that makes the animation back to start and then rewind to where you were (added: 8e6c7a6)
  • 18) Double click to bring the value menu
  • 19) Folders or parents should proxy the keyframes beneath them (added: d19d0ef).

@honzapatCZ
Copy link
Contributor

honzapatCZ commented Jul 17, 2021

  • 20) adding to the @W2Wizard scrolling,
    Shift + Scroll could move horizontally on the timeline (fix: 5b05c6c)
    Ctrl + Scoll could scale as is, but around the current time(or mouse position idk which one is better) in timeline, not the start (fix: ee29a1b)

@honzapatCZ
Copy link
Contributor

honzapatCZ commented Jul 24, 2021

  • 21) Audio Tracks, Camera tracks and SubScene tracks should behavely differently, rather than limiting the whole track for single asset(and only once), have them just limit to the use type, ie Camera for camera and let it take any cameras(yes you will loose the ability to tween camera's properties, but thats ok), similiar with audio(add copying of the track, stretching and most importantly not limit it to single audio file, let it be free, this way much less space will be wasted) (added: 0ec16de)

@mafiesto4
Copy link
Member Author

  • 22) Panning the timeline with a right-mouse button over background (added: 94b4c20)

flaxtechnology pushed a commit that referenced this issue Sep 21, 2021
@mafiesto4
Copy link
Member Author

After a few weeks, all of those issues are done! If case of new feature requests or bugs for scene animations please report them separately.
Cut-Scenes editing is way more usable now.

camera-cuts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working editor
Projects
None yet
Development

No branches or pull requests

3 participants