Visject: Improved comment renaming + visual fix #2652
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mafiesto4
added
enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When renaming a comment in visject and the comment happens to not be fully visible in the visject window, the rename popup will be drawn outside the window.
This PR replaces the RenamePopup with a textbox inside the comment header itself. This is more in line with how other graph tools handle this case.
Fixes #2006
Additionally pressing ESC now will no longer apply the new name.
Note: I actually wanted the textbox text to align with the title. In the center. But this is currently buggy. See #2653. When the issue gets fixed i might change the alignment here as well.
Preview
Renaming before
Renaming after
Of course this means, that the textbox will now be cut off when renaming a comment that is outside the window. But i would argue that this is the expected behaviour. I also checked and other graph tools seem to just do the same.
