Skip to content
This repository has been archived by the owner on Dec 16, 2019. It is now read-only.

remove quotes from assert assertions #20

Merged
merged 12 commits into from
Jan 9, 2018
Merged

remove quotes from assert assertions #20

merged 12 commits into from
Jan 9, 2018

Conversation

lrobi2014
Copy link
Contributor

No description provided.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 99.057% when pulling 5ded5ac on lrobi2014:fix/remove-deprecated-strings-as-assertions into 26accd7 on Fleshgrinder:master.

@Fleshgrinder Fleshgrinder self-assigned this Jan 5, 2018
@Fleshgrinder Fleshgrinder self-requested a review January 5, 2018 20:53
@Fleshgrinder
Copy link
Owner

@lrobi2014 thanks for the contribution. 👍

We have to remove PHP 5 support for this change to happen. As you might have guessed, that is the reason why the assertions are still strings in this library.

Could you remove the .idea changes from this PR?

@lrobi2014
Copy link
Contributor Author

@Fleshgrinder No problem, will do.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 99.057% when pulling 82b3c80 on lrobi2014:fix/remove-deprecated-strings-as-assertions into 26accd7 on Fleshgrinder:master.

@Fleshgrinder
Copy link
Owner

We have to drop support for PHP 5 otherwise the code within the assert calls is always executed, regardless of settings.

Please revert all changes to the .idea directory.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 99.057% when pulling d4986a5 on lrobi2014:fix/remove-deprecated-strings-as-assertions into 26accd7 on Fleshgrinder:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 99.057% when pulling 8b28192 on lrobi2014:fix/remove-deprecated-strings-as-assertions into 26accd7 on Fleshgrinder:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 99.057% when pulling 49b8848 on lrobi2014:fix/remove-deprecated-strings-as-assertions into 26accd7 on Fleshgrinder:master.

@coveralls
Copy link

coveralls commented Jan 9, 2018 •
edited

Coverage Status

Coverage remained the same at 99.057% when pulling a8db4bf on lrobi2014:fix/remove-deprecated-strings-as-assertions into 26accd7 on Fleshgrinder:master.

@coveralls
Copy link

coveralls commented Jan 9, 2018 •
edited

Coverage Status

Coverage remained the same at 99.057% when pulling 6d612aa on lrobi2014:fix/remove-deprecated-strings-as-assertions into 26accd7 on Fleshgrinder:master.

@coveralls
Copy link

coveralls commented Jan 9, 2018 •
edited

Coverage Status

Coverage remained the same at 99.057% when pulling 20f857b on lrobi2014:fix/remove-deprecated-strings-as-assertions into 26accd7 on Fleshgrinder:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 99.057% when pulling 04589e5 on lrobi2014:fix/remove-deprecated-strings-as-assertions into 26accd7 on Fleshgrinder:master.

@Fleshgrinder Fleshgrinder merged commit 98d8291 into Fleshgrinder:master Jan 9, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Fleshgrinder Fleshgrinder Fleshgrinder approved these changes

Assignees

@Fleshgrinder Fleshgrinder

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@lrobi2014 @coveralls @Fleshgrinder