Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem with states which have the same type #15

Closed
GabrielHuettenberger opened this issue May 15, 2018 · 2 comments
Closed

Problem with states which have the same type #15

GabrielHuettenberger opened this issue May 15, 2018 · 2 comments

Comments

@GabrielHuettenberger
Copy link

When having two state types with identical names in different state packages, the App only shows one of the two types twice when using the Add State feature. Which type is shown twice seems to change randomly on App restart.
state_type1
state_types2

@pschillinger
Copy link
Member

Thanks for reporting, I will look into it.

Independent of this, I would suggest to give rather specific names to states and make sure that states are indeed different in the sense that they are more than just two different hardcoded parametrizations of the same functionality. But of course, the issue you reported needs to be fixed.

@pschillinger pschillinger self-assigned this Jun 30, 2018
@pschillinger
Copy link
Member

This problem should be fixed now by the above referenced commit.

In short:

  • Duplicate state class names are now correctly handled within the app.
  • For generated code, duplicate state classes are imported with according aliases. This enables to correctly load the respective state class when loading a behavior in the app.
  • There is a new entry in the settings to do the above explicitly for all state classes even if unique.

@pschillinger pschillinger removed their assignment Nov 30, 2018
ffriese added a commit to ffriese/flexbe_app that referenced this issue Jan 9, 2019
fmessmer added a commit to fmessmer/flexbe_app that referenced this issue Jun 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants