Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'flexbe_behavior_engine' to package.xml #39

Closed
wants to merge 1 commit into from

Conversation

RhysMcK
Copy link

@RhysMcK RhysMcK commented Aug 16, 2019

Helpfully as it allows rosdep install to resolve this dependency and automatically install the flexbe_behavior_engine package.

@pschillinger
Copy link
Member

Thanks for adding, sounds generally reasonable. However, flexbe_behavior_engine is a metapackage, that means, other packages cannot depend on it (see REP127). The build currently fails due to this.

A workaround could be to list the FlexBE packages explicitly. Still, strictly speaking, the are no real dependencies in the sense that there are any imports. What do you think?

@pschillinger pschillinger changed the base branch from master to develop August 17, 2019 12:59
@RhysMcK
Copy link
Author

RhysMcK commented Aug 19, 2019

ah right ofcourse, i was forgetting it was a meta!

Still, strictly speaking, the are no real dependencies in the sense that there are any imports.

Yeah I see your point. It is a little bit of semantics i guess if the flexbe_app has a run_time dependency on the flexbe_behavior_engine (well the individual packages). Although the flexbe_app doesn't error/complain, it still losses the 'Runtime control' functionality. And also, the launch files will all fail. I don't really have a strong opinion on the matter. Sounds like how it currently is best fits the ROS standard, so happy to close the PR.

@StefanFabian
Copy link

Checking in because switching the Team Hector workspace to a central debian package repository brought up a similar issue.
In my opinion since the launch files are explicitly using these packages, there should be a run_depend.
The packages that it would need a run depend on are: flexbe_onboard, flexbe_widget and flexbe_mirror.

PS: Greetings from Darmstadt @pschillinger

pschillinger added a commit that referenced this pull request Jan 8, 2020
@pschillinger
Copy link
Member

I now added the suggested run dependencies as well as the message dependencies in the above commit.

flexbe_core is an indirect dependency. flexbe_states is not part of the indirect dependencies, but it should be listed in the dependencies of a behavior package if used.

Will close here now since this update should fulfill the request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants