Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spanish translation #21

Closed
jorgeaaq70 opened this issue Apr 23, 2024 · 7 comments
Closed

Spanish translation #21

jorgeaaq70 opened this issue Apr 23, 2024 · 7 comments

Comments

@jorgeaaq70
Copy link
Contributor

I create the ADMX files for es-ES with spanish translation but I can not get that FlexConfirmMail use them

I need to do anything else?

Attached are the spanish translated version ... (change the extension for upload)

FlexConfirmMailDefault.adml.txt
FlexConfirmMail.adml.txt

I put the files in \domain.com\SYSVOL\csags.com.mx\Policies\PolicyDefinitions

English version work , but I cannot get the spanish version to work

@HashidaTKS
Copy link
Contributor

HashidaTKS commented Apr 24, 2024

I put the files in \domain.com\SYSVOL\csags.com.mx\Policies\PolicyDefinitions

Please let me check, did you put those translated adml files to \domain.com\SYSVOL\csags.com.mx\Policies\PolicyDefinitions\es-ES and admx files to \domain.com\SYSVOL\csags.com.mx\Policies\PolicyDefinitions ?

Attached are the spanish translated version ... (change the extension for upload)

It seems that following settings are incorrect.

FlexConfirmMailDefault.adml

    <presentationTable>
      <presentation id="CountSeconds">
        <decimalTextBox refId="ContarSegundos" defaultValue="3" spinStep="1">Segundos</decimalTextBox>
      </presentation>
      <presentation id="SafeBccThreshold">
        <decimalTextBox refId="UmbralBccSeguros" defaultValue="4" spinStep="1">Numero de Dominios</decimalTextBox>
      </presentation>
      <presentation id="TrustedDomains">
        <multiTextBox refId="DominiosSeguros"/>
      </presentation>
      <presentation id="UnsafeDomains">
        <multiTextBox refId="DominiosInseguros"/>
      </presentation>
      <presentation id="UnsafeFiles">
        <multiTextBox refId="ArchivosInseguros"/>
      </presentation>
    </presentationTable>

You should specify a corresponding id in the admx file as refid.

    <presentationTable>
      <presentation id="CountSeconds">
        <decimalTextBox refId="CountSeconds" defaultValue="3" spinStep="1">Segundos</decimalTextBox>
      </presentation>
      <presentation id="SafeBccThreshold">
        <decimalTextBox refId="SafeBccThreshold" defaultValue="4" spinStep="1">Numero de Dominios</decimalTextBox>
      </presentation>
      <presentation id="TrustedDomains">
        <multiTextBox refId="TrustedDomains"/>
      </presentation>
      <presentation id="UnsafeDomains">
        <multiTextBox refId="UnsafeDomains"/>
      </presentation>
      <presentation id="UnsafeFiles">
        <multiTextBox refId="UnsafeFiles"/>
      </presentation>
    </presentationTable>

Also, please note that FlexConfirmMail's UI does not support Spanish, even if these adml files work correctly.

@HashidaTKS
Copy link
Contributor

HashidaTKS commented Apr 24, 2024

Also, please note that FlexConfirmMail's UI does not support Spanish, even if these adml files work correctly.

We also welcome a PR for translating the UI resource files for Spanish :)
(means Resources.es.resx)

https://github.com/FlexConfirmMail/Outlook/tree/master/Properties

@jorgeaaq70
Copy link
Contributor Author

I am going to change the files and probe

but, I do my FIRST contribution to a project on Github with the files Resources.es.resx with the Translation for the UI to spanish!! and the translated files for policy es-ES

@HashidaTKS
Copy link
Contributor

HashidaTKS commented Apr 26, 2024

Thank you, all PRs are merged. They will be reflected in the next release.

@jorgeaaq70
Copy link
Contributor Author

Hi, I do not have the tools to create the executable, can someone help me compiling and publishing the exec with the new language please!

thanks in advance

@HashidaTKS
Copy link
Contributor

Sorry for my lack of information.

We create an installer with CI.
You can download the latest installer from artifacts of the CI.

https://github.com/FlexConfirmMail/Outlook/actions/runs/8903771983

@HashidaTKS
Copy link
Contributor

Close because we now release v22.7 that includes this change.

https://github.com/FlexConfirmMail/Outlook/releases/tag/v22.7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants