Anime command, Jikan MAL API #33
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
germanoeich
requested changes
Apr 7, 2018
src/commands/Anime.js
Outdated
| } | ||
|
|
||
| async execute({ message, args }) { | ||
| let msg = await this.sendMessage(message.channel, { |
There was a problem hiding this comment.
msg is not reassigned, in that case it's better to use const instead of let
src/commands/Anime.js
Outdated
| { | ||
| name: 'Description', | ||
| value: `${anime.description}`, | ||
| inline: true, |
There was a problem hiding this comment.
Since this is the last field and the biggest, I think it makes sense for it to not be inline and take up a whole row
src/commands/Anime.js
Outdated
| embed: { | ||
| color: 0x337fd5, | ||
| thumbnail: { | ||
| url: 'https://cdn.discordapp.com/emojis/397911964988342282.gif', |
There was a problem hiding this comment.
Discord CDNs can't be trusted, as the content may dissapear without further notice, or someone may delete the emoji.
I have uploaded that to our own CDN, mind chaning the link? https://cdn.dyno.gg/fun/discord_loading.gif
retrying, changed let to const, gif link and deleted inline from last field
germanoeich
approved these changes
Apr 7, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Searches anime based on the search args and returns the first result (from MyAnimeList)
(first time, be gentle)