refactor: review suggestions, changed test asserts

Signed-off-by: GustaafL <guus@seita.nl>
FlexMeasures · Jul 19, 2023 · cf83385 · cf83385
1 parent fa465c8
commit cf83385
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 11 deletions.
diff --git a/flexmeasures/api/v3_0/sensors.py b/flexmeasures/api/v3_0/sensors.py
@@ -529,5 +529,4 @@ def fetch_one(self, id, sensor):
         :status 403: INVALID_SENDER
         :status 422: UNPROCESSABLE_ENTITY
         """
-        sensor = Sensor.query.filter(Sensor.id == 1).one_or_none()
         return sensor_schema.dump(sensor), 200
diff --git a/flexmeasures/api/v3_0/tests/test_sensors_api.py b/flexmeasures/api/v3_0/tests/test_sensors_api.py
@@ -13,23 +13,17 @@ def test_fetch_one_sensor(
     setup_api_test_data: dict[str, Sensor],
 ):
     sensor_id = 1
-    assert_response = {
-        "name": "some gas sensor",
-        "unit": "m³/h",
-        "entity_address": "ea1.2023-08.localhost:fm1.1",
-        "event_resolution": 10,
-        "generic_asset_id": 4,
-        "timezone": "UTC",
-        "status": 200,
-    }
     headers = make_headers_for("test_supplier_user_4@seita.nl", client)
     response = client.get(
         url_for("SensorAPI:fetch_one", id=sensor_id),
         headers=headers,
     )
     print("Server responded with:\n%s" % response.json)
     assert response.status_code == 200
-    assert response.json == assert_response
+    assert response.json["name"] == "some gas sensor"
+    assert response.json["unit"] == "m³/h"
+    assert response.json["generic_asset_id"] == 4
+    assert response.json["timezone"] == "UTC"
 
 
 def make_headers_for(user_email: str | None, client) -> dict: