Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Regression: analytics selections malfunctioning #116

Closed
Flix6x opened this issue May 4, 2021 · 1 comment · Fixed by #117
Closed

Regression: analytics selections malfunctioning #116

Flix6x opened this issue May 4, 2021 · 1 comment · Fixed by #117
Assignees
@Flix6x
Labels
bug Something isn't working UI
Milestone
0.4.1

Comments

@Flix6x
Copy link
Contributor

Flix6x commented May 4, 2021

When selecting a resource:

analytics:269 Uncaught ReferenceError: submit_resource is not defined
    at HTMLSelectElement.onchange (analytics:269)

When selecting a market:

onchange @ analytics:269
analytics:649 Uncaught ReferenceError: submit_market is not defined
    at HTMLSelectElement.onchange (analytics:649)

When selecting a different weather sensor:

onchange @ analytics:649
analytics:688 Uncaught ReferenceError: submit_sensor_type is not defined
    at HTMLSelectElement.onchange (analytics:688)

This seems to be caused by redefining flexmeasures.js as a module type script in base.html.
@Flix6x Flix6x added bug Something isn't working UI labels May 4, 2021
@Flix6x Flix6x self-assigned this May 4, 2021
@create-issue-branch
Copy link
Contributor

Branch issue-116-Regression_analytics_selections_malfunctioning created!

create-issue-branch bot pushed a commit that referenced this issue May 4, 2021
@Flix6x
Create draft PR for #116
ae3c717
@create-issue-branch create-issue-branch bot mentioned this issue May 4, 2021
Merged
@Flix6x Flix6x modified the milestones: 0.4.0, 0.4.1 May 4, 2021
Flix6x added a commit that referenced this issue May 7, 2021
@create-issue-branch @Flix6x
Regression: analytics selections malfunctioning (#117)
93ca7d5 
Fixed regression and started more targeted loading of javascript functions from our own js modules.


* Create draft PR for #116

* Fix bug due to redefining older javascript content as a js module.

* Changelog entry

* More targeted loading of js functions from module

Co-authored-by: Flix6x <Flix6x@users.noreply.github.com>
Co-authored-by: F.N. Claessen <felix@seita.nl>
Co-authored-by: Felix Claessen <30658763+Flix6x@users.noreply.github.com>
Flix6x added a commit that referenced this issue May 7, 2021
@create-issue-branch @Flix6x
Backport #117: Regression: analytics selections malfunctioning (#117)
243c483 
Fixed regression and started more targeted loading of javascript functions from our own js modules.

* Create draft PR for #116

* Fix bug due to redefining older javascript content as a js module.

* Changelog entry

* More targeted loading of js functions from module

Co-authored-by: Flix6x <Flix6x@users.noreply.github.com>
Co-authored-by: F.N. Claessen <felix@seita.nl>
Co-authored-by: Felix Claessen <30658763+Flix6x@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Flix6x Flix6x

Labels
bug Something isn't working UI
Projects
None yet
Milestone
0.4.1
Development

Successfully merging a pull request may close this issue.

Regression: analytics selections malfunctioning FlexMeasures/flexmeasures
1 participant
@Flix6x