fix: replay key conflict with text input #1024
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g a listing on the asset page shouldn't trigger replay functionality Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: F.N. Claessen <felix@seita.nl>
nrozanov
approved these changes
Apr 15, 2024
Flix6x
added a commit
that referenced
this pull request
May 6, 2024
* fix: inputting a 'p' or an 's' while editing an attribute or filtering a listing on the asset page shouldn't trigger replay functionality Signed-off-by: F.N. Claessen <felix@seita.nl> * docs: changelog entry Signed-off-by: F.N. Claessen <felix@seita.nl> --------- Signed-off-by: F.N. Claessen <felix@seita.nl> (cherry picked from commit d407a21)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Inputting a 'p' or an 's' while editing an attribute or filtering a listing on the asset page shouldn't trigger replay functionality.
How to test
Go to an asset page and in the sensor listing filter records by the letter p or s. The replay shouldn't start or stop. Likewise for editing asset attributes.