Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scheduling jobs on status page #1035

Merged
merged 16 commits into from
Apr 19, 2024
Merged

Scheduling jobs on status page #1035

merged 16 commits into from
Apr 19, 2024

Conversation

nrozanov
Copy link
Contributor

Description

Extend the current status page - add a simple table on the right of the data connectivity (or beneath) and show the last 10 or 20 jobs, with green or red lights, and with their status/error message available in a tool-tip or on click

Look & Feel

New table on the status page, containing data about latest asset jobs

How to test

Create some jobs for an asset, check they appear on status page of this asset

Further Improvements

.

Related Items

.

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on code under GPL or other license that is incompatible with FlexMeasures

@nrozanov
add job cache by sensor id in create forecasting jobs
173e353 
Signed-off-by: Nikolai Rozanov <nickolay.rozanov@gmail.com>
@nrozanov nrozanov linked an issue Apr 10, 2024 that may be closed by this pull request
Scheduling jobs on status page #1032
Closed
@nhoening nhoening changed the title add job cache by sensor id in create forecasting jobs Scheduling jobs on status page Apr 10, 2024
nhoening
nhoening requested changes Apr 10, 2024
View reviewed changes
Copy link
Contributor

@nhoening nhoening left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the approach. I found a way to make it a bit simpler. And it should deal with scheduling.

flexmeasures/data/services/forecasting.py Outdated Show resolved Hide resolved
flexmeasures/data/services/job_cache.py Outdated Show resolved Hide resolved
flexmeasures/data/services/job_cache.py Show resolved Hide resolved
flexmeasures/data/tests/test_job_cache.py Show resolved Hide resolved
flexmeasures/conftest.py Outdated Show resolved Hide resolved
@nrozanov
fixes after review + split cache key by queue type and sensor/asset +…
65da854 
… use job_cache for scheduling jobs

Signed-off-by: Nikolai Rozanov <nickolay.rozanov@gmail.com>
@nrozanov
Return job data on GET assets/id/status + add tables for forecasting …
cbb5a17 
…and scheduling jobs on status page

Signed-off-by: Nikolai Rozanov <nickolay.rozanov@gmail.com>
nhoening
nhoening requested changes Apr 13, 2024
View reviewed changes
Copy link
Contributor

@nhoening nhoening left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, I like the structure.

Most comments about style & names. Very few about functionality.

flexmeasures/data/services/job_cache.py Outdated Show resolved Hide resolved
flexmeasures/data/services/scheduling.py Outdated Show resolved Hide resolved
flexmeasures/data/services/scheduling.py Outdated Show resolved Hide resolved
flexmeasures/data/services/sensors.py Outdated Show resolved Hide resolved
flexmeasures/data/services/sensors.py Outdated Show resolved Hide resolved
flexmeasures/data/services/job_cache.py Outdated Show resolved Hide resolved
flexmeasures/data/services/job_cache.py Outdated Show resolved Hide resolved
flexmeasures/ui/templates/views/status.html Show resolved Hide resolved
flexmeasures/data/services/job_cache.py Outdated Show resolved Hide resolved
flexmeasures/ui/templates/views/status.html Outdated Show resolved Hide resolved
@nrozanov
Styling + annotations
5c0fbd4 
Signed-off-by: Nikolai Rozanov <nickolay.rozanov@gmail.com>
@nrozanov
Fix for job/job.id url on status page
766b5f5 
Signed-off-by: Nikolai Rozanov <nickolay.rozanov@gmail.com>
@nrozanov
Better redis connection exception handling
7a1166d 
Signed-off-by: Nikolai Rozanov <nickolay.rozanov@gmail.com>
@nrozanov
Back to asset page button
afcd447 
Signed-off-by: Nikolai Rozanov <nickolay.rozanov@gmail.com>
@nrozanov
Merge main
f910abf 
Signed-off-by: Nikolai Rozanov <nickolay.rozanov@gmail.com>
nhoening
nhoening requested changes Apr 16, 2024
View reviewed changes
Copy link
Contributor

@nhoening nhoening left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I get more ideas while I try this, sorry.
Also found a few small things I want to improve.

Uninstalling highspy was a great way for me to test failing jobs, by the way.

flexmeasures/data/services/sensors.py Outdated Show resolved Hide resolved
flexmeasures/data/services/sensors.py Outdated Show resolved Hide resolved
flexmeasures/ui/templates/views/status.html Show resolved Hide resolved
flexmeasures/ui/crud/assets.py Outdated Show resolved Hide resolved
flexmeasures/data/services/sensors.py Outdated Show resolved Hide resolved
flexmeasures/ui/templates/views/status.html Show resolved Hide resolved
flexmeasures/ui/crud/assets.py Outdated Show resolved Hide resolved
@nrozanov
Review fixes + 'Created at' column to job tables + sort by this column
ffaf8aa 
Signed-off-by: Nikolai Rozanov <nickolay.rozanov@gmail.com>
@nrozanov
Merge main
3ca1afc 
Signed-off-by: Nikolai Rozanov <nickolay.rozanov@gmail.com>
@nrozanov
Changelog
75a185f 
Signed-off-by: Nikolai Rozanov <nickolay.rozanov@gmail.com>
nhoening
nhoening requested changes Apr 17, 2024
View reviewed changes
Copy link
Contributor

@nhoening nhoening left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Just two very small comments left for me.

documentation/changelog.rst Outdated Show resolved Hide resolved
flexmeasures/ui/templates/views/status.html Outdated Show resolved Hide resolved
@nhoening
Copy link
Contributor

The type annotations do not work on Python3.8: https://github.com/FlexMeasures/flexmeasures/actions/runs/8712586908/job/23899218536?pr=1035

It seems that job_cache.py needs from __future__ import annotations

@nrozanov
Post review fixes
e5e6e78 
Signed-off-by: Nikolai Rozanov <nickolay.rozanov@gmail.com>
@nrozanov
Merge main
a1f990d 
Signed-off-by: Nikolai Rozanov <nickolay.rozanov@gmail.com>
@nhoening
Copy link
Contributor

You seem to have some import problems

@nrozanov
Fix after spoiled main merge + fix annotations
54d3055 
Signed-off-by: Nikolai Rozanov <nickolay.rozanov@gmail.com>
Flix6x
Flix6x reviewed Apr 19, 2024
View reviewed changes
logfile Outdated Show resolved Hide resolved
@nrozanov
Remove redundant file
127892d 
Signed-off-by: Nikolai Rozanov <nickolay.rozanov@gmail.com>
nhoening
nhoening approved these changes Apr 19, 2024
View reviewed changes
Copy link
Contributor

@nhoening nhoening left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks!

@nhoening
add exact enqueue time for users hovering, fix hovering info for job …
ae1c45d 
…status

Signed-off-by: Nicolas Höning <nicolas@seita.nl>
@nhoening nhoening merged commit 031d6d6 into main Apr 19, 2024
7 of 9 checks passed
@nhoening nhoening deleted the status-page-scheduling-jobs branch April 19, 2024 18:42
@Flix6x Flix6x added this to the 0.21.0 milestone May 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nhoening nhoening nhoening approved these changes

@Flix6x Flix6x Flix6x left review comments

Assignees

@nrozanov nrozanov

Labels
None yet
Projects
None yet
Milestone
0.21.0
Development

Successfully merging this pull request may close these issues.

Scheduling jobs on status page
3 participants
@nrozanov @nhoening @Flix6x