Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: show tooltip titles on touch screens #1062

Merged
merged 2 commits into from
Jun 20, 2024

Conversation

Flix6x
Copy link
Contributor

@Flix6x Flix6x commented May 14, 2024

Description

  • Adds the touched class to the html body, allowing custom css for touchscreens.
  • Show tooltips on touchscreens, based on the title attribute of html elements.
  • I added this as core FM functionality in base.html so plugins can use it, too (this was my primary concern).

Look & Feel

image

How to test

ngrok http 5000

Use your phone to visit pages with tooltips, such as table items on the /users, /assets and /asset/<id> pages.

Signed-off-by: F.N. Claessen <felix@seita.nl>
@Flix6x Flix6x requested a review from nrozanov May 14, 2024 10:27
@Flix6x Flix6x self-assigned this May 14, 2024
@nhoening nhoening added this to the 0.22.0 milestone May 16, 2024
Signed-off-by: Nicolas Höning <nicolas@seita.nl>
@nhoening nhoening merged commit 3aced24 into main Jun 20, 2024
9 checks passed
@nhoening nhoening deleted the feature/tooltips-on-touchscreens branch June 20, 2024 17:12
@Flix6x
Copy link
Contributor Author

Flix6x commented Jun 21, 2024

Still needed a changelog entry.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants