Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: show default sensors of the same unit together #1066

Merged
merged 7 commits into from
May 31, 2024

Conversation

Flix6x
Copy link
Contributor

@Flix6x Flix6x commented May 21, 2024

Description

In case of an asset with two power sensors (or two price sensors, two temperature sensors, or any two sensors sharing the same unit), the asset's data chart more often than not becomes more insightful when the plots of the sensor data—two sensors are shown by default—overlap, and thus share the same y-axis.

Look & Feel

Before:

asset-40-Amsterdam-before

After:

asset-40-Amsterdam-after

Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: F.N. Claessen <felix@seita.nl>
@Flix6x Flix6x marked this pull request as ready for review May 21, 2024 10:55
@Flix6x Flix6x added this to the 0.22.0 milestone May 21, 2024
@Flix6x Flix6x requested a review from nhoening May 21, 2024 10:55
Flix6x and others added 2 commits May 21, 2024 12:56
Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: Felix Claessen <30658763+Flix6x@users.noreply.github.com>
Copy link
Contributor

@nhoening nhoening left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice addition, I would only alter the changelog message

documentation/changelog.rst Outdated Show resolved Hide resolved
Co-authored-by: Nicolas Höning <nicolas@seita.nl>
Signed-off-by: Felix Claessen <30658763+Flix6x@users.noreply.github.com>
@Flix6x Flix6x merged commit 77f7b77 into main May 31, 2024
3 checks passed
@Flix6x Flix6x deleted the feature/if-applicable-share-y-axis-by-default branch May 31, 2024 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants