Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Asset audit log #1072

Merged
merged 13 commits into from
Jun 6, 2024
Merged

Asset audit log #1072

merged 13 commits into from
Jun 6, 2024

Conversation

nrozanov
Copy link
Contributor

@nrozanov nrozanov commented May 27, 2024 •
edited
Loading

Description

Start adding audit log records for asset related actions.

Look & Feel

New router assets//auditlog shows account audit log records

How to test

Create an asset, edit it, add / remove sensors, go to auditlog and these actions should be displayed there

Further Improvements

Related Items

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on code under GPL or other license that is incompatible with FlexMeasures

@nrozanov
Asset audit log
2adb705 
Signed-off-by: Nikolai Rozanov <nickolay.rozanov@gmail.com>
@nrozanov nrozanov requested a review from nhoening May 27, 2024 08:39
@nrozanov
Merge main
68c22ac 
Signed-off-by: Nikolai Rozanov <nickolay.rozanov@gmail.com>
@nrozanov nrozanov linked an issue May 27, 2024 that may be closed by this pull request
Audit log for assets #1067
Closed
@nrozanov
Add import for migration file
efd2fef 
Signed-off-by: Nikolai Rozanov <nickolay.rozanov@gmail.com>
@nrozanov
Migration file + small fixes
2872d04 
Signed-off-by: Nikolai Rozanov <nickolay.rozanov@gmail.com>
@nrozanov
Merge main
5f4f611 
Signed-off-by: Nikolai Rozanov <nickolay.rozanov@gmail.com>
nhoening
nhoening requested changes May 30, 2024
View reviewed changes
Copy link
Contributor

@nhoening nhoening left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool - I tested it, and it works nicely.
My comments are about small refactorings only, or questions, I believe.

documentation/changelog.rst Outdated Show resolved Hide resolved
flexmeasures/api/v3_0/assets.py Outdated Show resolved Hide resolved
flexmeasures/data/migrations/versions/126d65cbe6b4_asset_audit_log.py Show resolved Hide resolved
flexmeasures/api/v3_0/sensors.py Outdated Show resolved Hide resolved
flexmeasures/api/v3_0/tests/test_assets_api.py Show resolved Hide resolved
flexmeasures/cli/data_edit.py Outdated Show resolved Hide resolved
flexmeasures/cli/tests/test_data_edit.py Show resolved Hide resolved
flexmeasures/cli/tests/test_data_edit.py Outdated Show resolved Hide resolved
flexmeasures/data/schemas/sensors.py Show resolved Hide resolved
flexmeasures/ui/templates/crud/asset.html Outdated Show resolved Hide resolved
Nikolai added 4 commits June 3, 2024 11:57
Fixes after review
38ac12e 
Signed-off-by: Nikolai <nrozanov@iponweb.net>
Run pre commit
29cd6d7 
Signed-off-by: Nikolai <nrozanov@iponweb.net>
Merge main
4221288 
Signed-off-by: Nikolai <nrozanov@iponweb.net>
Merge main
88a30a6 
Signed-off-by: Nikolai <nrozanov@iponweb.net>
nhoening
nhoening requested changes Jun 4, 2024
View reviewed changes
Copy link
Contributor

@nhoening nhoening left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good. I tried it out and noticed two problems.

flexmeasures/ui/templates/crud/asset.html Outdated Show resolved Hide resolved
flexmeasures/ui/templates/crud/asset.html Show resolved Hide resolved
Nikolai and others added 4 commits June 5, 2024 13:48
Fixes after review
6547e20 
Signed-off-by: Nikolai <nrozanov@iponweb.net>
Migration fix
2fd8103 
Signed-off-by: Nikolai <nrozanov@iponweb.net>
@nhoening
make sure action buttons are full width
9521cc8 
Signed-off-by: Nicolas Höning <nicolas@seita.nl>
@nhoening
Merge branch 'main' into asset-audit-log
30a8c81 
Signed-off-by: Nicolas Höning <nicolas@seita.nl>
nhoening
nhoening approved these changes Jun 6, 2024
View reviewed changes
Copy link
Contributor

@nhoening nhoening left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@nhoening nhoening merged commit d0e8f61 into main Jun 6, 2024
9 checks passed
@nhoening nhoening deleted the asset-audit-log branch June 6, 2024 15:15
@nhoening nhoening added this to the 0.22.0 milestone Jun 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nhoening nhoening nhoening approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.22.0
Development

Successfully merging this pull request may close these issues.

Audit log for assets
2 participants
@nrozanov @nhoening