Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Choose better weather forecasting horizons #131

Merged
merged 5 commits into from May 14, 2021
Merged

Conversation

nhoening
Copy link
Contributor

@nhoening nhoening commented May 11, 2021

If weather data is posted which is itself not forecasts, we should choose better forecasts for forecasting.

Also: add choices for horizons if the data resolution is smaller than 15 minutes.

@nhoening nhoening requested a review from Flix6x May 11, 2021
Flix6x
Flix6x approved these changes May 12, 2021
[
job
for job in app.queues["forecasting"].jobs
if job.kwargs["timed_value_type"] != "Price"
Copy link
Contributor

@Flix6x Flix6x May 12, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are you checking for != "Price" instead of == "Weather"? Also in line 224.

jobs = [
job
for job in app.queues["forecasting"].jobs
if job.kwargs["timed_value_type"] != "Price"
Copy link
Contributor

@Flix6x Flix6x May 12, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just flagging one more occurrence. Candidate util function?

sorted(jobs, key=lambda x: x.kwargs["horizon"]), forecast_horizons
):
assert job.kwargs["horizon"] == horizon
assert job.kwargs["start"] == parse_date(post_message["start"]) + horizon
Copy link
Contributor

@Flix6x Flix6x May 12, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A comment would be useful for this one, not self evident.

@nhoening nhoening merged commit 50d668c into main May 14, 2021
2 checks passed
@Flix6x Flix6x deleted the weather-forecasting-horizons branch Mar 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants