Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sensor charts load most recent beliefs by default #307

merged 1 commit into from Jan 12, 2022


Copy link

@Flix6x Flix6x commented Jan 10, 2022

This PR represents a significant speed-up for loading charts of sensors with many beliefs, such as charts for power actuators whose planned schedules are updated many times before actuation.

Signed-off-by: F.N. Claessen <>
@Flix6x Flix6x added the UI label Jan 10, 2022
@Flix6x Flix6x requested a review from nhoening January 10, 2022 15:19
@Flix6x Flix6x self-assigned this Jan 10, 2022
Copy link

@nhoening nhoening left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve this message!

Another way to achieve this would have been to make most_recent_beliefs_only on Sensor.search_beliefs.

Why isn't that the case actually?

Copy link
Contributor Author

Flix6x commented Jan 12, 2022

Because that would have been a breaking change to the function signature of Sensor.search_beliefs. I do agree it would be a sensible default, though. Shall I make another ticket for that?

@Flix6x Flix6x merged commit f7c6ab0 into project-9 Jan 12, 2022
@Flix6x Flix6x deleted the sensor-charts-load-most-recent-beliefs-by-default branch January 12, 2022 10:12
Copy link

Yes that seems like a good idea.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet

Successfully merging this pull request may close these issues.

None yet

2 participants