Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

load leaflet js from CDN in two more locations #32

Merged
merged 1 commit into from Feb 19, 2021
Merged

load leaflet js from CDN in two more locations #32

merged 1 commit into from Feb 19, 2021

Conversation

nhoening
Copy link
Contributor

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or other license that is incompatible with FlexMeasures

@nhoening nhoening requested a review from Flix6x February 19, 2021 10:22
@nhoening nhoening self-assigned this Feb 19, 2021
Flix6x
Flix6x approved these changes Feb 19, 2021
View reviewed changes
Copy link
Contributor

@Flix6x Flix6x left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. I'll make a new ticket, though, for what this brings to light: to gather these dependencies in one place so we only need to upgrade in one place in our code.

@nhoening nhoening merged commit 92ca069 into main Feb 19, 2021
@nhoening nhoening deleted the issue-31-Asset_pages_still_try_loading_leaflet_js_from_disk_not_from_CDN branch February 19, 2021 10:51
@nhoening nhoening mentioned this pull request Feb 19, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Flix6x Flix6x Flix6x approved these changes

Assignees

@nhoening nhoening

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nhoening @Flix6x