Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up references to old sensor ids #342

Merged
merged 4 commits into from
Jan 31, 2022
Merged

Clean up references to old sensor ids #342

merged 4 commits into from
Jan 31, 2022

Conversation

Flix6x
Copy link
Contributor

@Flix6x Flix6x commented Jan 31, 2022

Upon encountering an occurrence of asset_id referring to old_sensor_id (in the CLI command flexmeasures add forecasts), I realized there was still some cleaning up to be done. Historical context: asset_id became old_sensor_id, which became sensor_id. Any occurence of asset_id in the CLI should now refer to generic_asset_id.

@Flix6x
Clean up CLI function to create forecasts
2f03854 
Signed-off-by: F.N. Claessen <felix@seita.nl>
@Flix6x
Replace remaining references to old_sensor_id with sensor_id
5dd3fdd 
Signed-off-by: F.N. Claessen <felix@seita.nl>
@Flix6x Flix6x requested a review from nhoening January 31, 2022 09:16
@Flix6x Flix6x self-assigned this Jan 31, 2022
nhoening
nhoening approved these changes Jan 31, 2022
View reviewed changes
Copy link
Contributor

@nhoening nhoening left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

flexmeasures/data/scripts/data_gen.py Outdated Show resolved Hide resolved
@Flix6x
Disallow forecasting all sensors at once, but allow forecasting multi…
50f4b22 
…ple sensors at once by explicitly passing their ids

Signed-off-by: F.N. Claessen <felix@seita.nl>
@Flix6x Flix6x requested a review from nhoening January 31, 2022 10:13
nhoening
nhoening requested changes Jan 31, 2022
View reviewed changes
flexmeasures/cli/data_add.py Outdated Show resolved Hide resolved
@Flix6x
Update docstring
30a5c7f 
Signed-off-by: F.N. Claessen <felix@seita.nl>
@Flix6x Flix6x requested a review from nhoening January 31, 2022 11:01
@Flix6x Flix6x merged commit d39abc7 into main Jan 31, 2022
@Flix6x Flix6x deleted the clean-up-references-to-old-sensor-ids branch January 31, 2022 12:20
@Flix6x Flix6x added this to the 0.9.0 milestone Feb 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nhoening nhoening nhoening approved these changes

Assignees

@Flix6x Flix6x

Labels
None yet
Projects
None yet
Milestone
0.9.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Flix6x @nhoening