-
Notifications
You must be signed in to change notification settings - Fork 38
Sensor chart ux improvements #447
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: F.N. Claessen <felix@seita.nl>
…at the bottom of the calendar Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: F.N. Claessen <felix@seita.nl>
…d in the y-axis label Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: F.N. Claessen <felix@seita.nl>
… being on the left Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: F.N. Claessen <felix@seita.nl>
…vigation can still be used Signed-off-by: F.N. Claessen <felix@seita.nl>
…st the sidepanel background Signed-off-by: F.N. Claessen <felix@seita.nl>
… the navbar-header accordingly Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: F.N. Claessen <felix@seita.nl>
…a dictionary with vega-lite specs Signed-off-by: F.N. Claessen <felix@seita.nl>
…st of years with the pointer. This stops the side panel from collapsing and reopening. Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: F.N. Claessen <felix@seita.nl>
…ar styling Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: F.N. Claessen <felix@seita.nl>
Thanks for the screenshots! Shouldn't the data plot move to the left if the date picker is collapsed? |
Pull Request Test Coverage Report for Build 2550022510
💛 - Coveralls |
Okay, I see. You mean "fixed" as in position-fixed. How does this look
on smaller screens?
…On Thu, 2022-06-23 at 08:18 -0700, Felix Claessen wrote:
You're welcome. The position of the data plot is meant to be fixed,
like so:
Peek 2022-06-23 17-15
.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you commented.Message ID:
***@***.***>
|
The expanding sidepanel will overlap the chart. For the smallest screen sizes, the sidepanel disappears, and its contents are shown above the chart (like we had before). |
I don't see the data plot moving into the free space. What is the fix?
Am 23. Juni 2022 17:18:24 MESZ schrieb Felix Claessen ***@***.***>:
You're welcome. The position of the data plot is meant to be fixed, like so:

..
--
Reply to this email directly or view it on GitHub:
#447 (comment)
You are receiving this because you commented.
Message ID: ***@***.***>
-- Gesendet von /e/ Mail.
|
No no, I didn't mean that anything is meant to be fixed—as in, resolving a problem. I meant that the plot area is meant to be fixed—as in, not moving. |
This PR introduces a collapsible sidepanel on the left of the sensor page, activated by hover or swipe, depending on the device. Also implements many smaller UX improvements: see the list below.