-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: docker image separated by dash not underscore, typo ) #453
Conversation
joyshmitz
commented
Jul 3, 2022
- I agree to contribute to the project under Apache 2 License.
- To the best of my knowledge, the proposed patch is not based on a code under GPL or other license that is incompatible with FlexMeasures
Pull Request Test Coverage Report for Build 2611811192
💛 - Coveralls |
Thanks, I'll check it out later today. I was also planning to work on extending the compose file with Redis and a queue worker, would that help you in your current project? |
If the question about Redis and queues is for me, then I just started studying your EMS, so the questions will come from testing. |
Yes sorry, I should've tagged you. You mean you are collecting meter data already, and might use FlexMeasures to make decisions? I imagine this setting makes sense especially if you only pass a subset of data (some sensors, lower resolution) to FlexMeasures. Just what is needed to decide what to do with flexible assets. |
that's right, and I'm trying to set up a test environment and get some hands-on experience with your software we have separate systems for collecting indicators of electricity and water meters, one writes everything in Postgres, the other in Mongo. They have an api, so I'm hoping to set up a machine-to-machine interaction/connection |
I confirmed this naming convention ("-" not "_") is happening. I'm not sure if this is due to an update in Docker and from which version (I re-installed my laptop recently, and now installed Docker Desktop, was on Docker engine before), but I'm fine with using this "-" convention here. Seems like the new standard. Can you please adjust lines 48-50 likewise? |
done |
Hey sorry, but the Linux Energy Foundation requires that all authors sign their commits. In the meantime, could you run this:
Thanks! |
Signed-off-by: Serhii <jshmitz@me.com>
Signed-off-by: Serhii <jshmitz@me.com>
thanks for the tip, did |
@joyshmitz maybe something for you, our next technical steering committee meeting, upcoming Thursday: https://lists.lfenergy.org/g/flexmeasures/message/7 |
Thank you. |