Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: docker image separated by dash not underscore, typo ) #453

Merged
merged 2 commits into from
Jul 4, 2022
Merged

docs: docker image separated by dash not underscore, typo ) #453

merged 2 commits into from
Jul 4, 2022

Conversation

joyshmitz
Copy link
Contributor

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or other license that is incompatible with FlexMeasures

@coveralls
Copy link
Collaborator

coveralls commented Jul 3, 2022

Pull Request Test Coverage Report for Build 2611811192

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 68.377%

Totals Coverage Status
Change from base Build 2560568268: 0.0%
Covered Lines: 7093
Relevant Lines: 9838

💛 - Coveralls

@nhoening
Copy link
Contributor

nhoening commented Jul 3, 2022

Thanks, I'll check it out later today. I was also planning to work on extending the compose file with Redis and a queue worker, would that help you in your current project?

@joyshmitz
Copy link
Contributor Author

joyshmitz commented Jul 4, 2022

If the question about Redis and queues is for me, then I just started studying your EMS, so the questions will come from testing.
I'm thinking about a connector with foreign bases: postgres, mongo
and this will be the plugin

@nhoening
Copy link
Contributor

nhoening commented Jul 4, 2022

Yes sorry, I should've tagged you.

You mean you are collecting meter data already, and might use FlexMeasures to make decisions?

I imagine this setting makes sense especially if you only pass a subset of data (some sensors, lower resolution) to FlexMeasures. Just what is needed to decide what to do with flexible assets.

@joyshmitz
Copy link
Contributor Author

joyshmitz commented Jul 4, 2022

that's right, and I'm trying to set up a test environment and get some hands-on experience with your software

we have separate systems for collecting indicators of electricity and water meters, one writes everything in Postgres, the other in Mongo.

They have an api, so I'm hoping to set up a machine-to-machine interaction/connection

@nhoening
Copy link
Contributor

nhoening commented Jul 4, 2022

I confirmed this naming convention ("-" not "_") is happening. I'm not sure if this is due to an update in Docker and from which version (I re-installed my laptop recently, and now installed Docker Desktop, was on Docker engine before), but I'm fine with using this "-" convention here. Seems like the new standard.

Can you please adjust lines 48-50 likewise?

@joyshmitz
Copy link
Contributor Author

done

@nhoening
Copy link
Contributor

nhoening commented Jul 4, 2022

Hey sorry, but the Linux Energy Foundation requires that all authors sign their commits.
This is mentioned here, but maybe we can make this more prominent. In practice, it only requires the -s flag with git commit.

In the meantime, could you run this:

git rebase HEAD~2 --signoff
git push --force-with-lease origin main

Thanks!

Signed-off-by: Serhii <jshmitz@me.com>
Signed-off-by: Serhii <jshmitz@me.com>
@joyshmitz
Copy link
Contributor Author

thanks for the tip, did

@nhoening nhoening merged commit cc70d03 into FlexMeasures:main Jul 4, 2022
@nhoening
Copy link
Contributor

@joyshmitz maybe something for you, our next technical steering committee meeting, upcoming Thursday: https://lists.lfenergy.org/g/flexmeasures/message/7

@joyshmitz
Copy link
Contributor Author

Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants