Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

do not fail the sensor attribute when building an entity address #457


Copy link

@nhoening nhoening commented Jul 7, 2022

Closes #456

Do warn about failure to build entity addresses, however.

This particular failure to build them has to do with the domain FlexMeasures runs on, which becomes part of the address.
When FlexMeasuresa starts, we don't know the domain ― currently, we find out where we run on request information.

Thus, warning about this failure in the terminal when FlexMeasures starts seems difficult. The failure becomes visual when the asset page is visited ("no entity address available"), so it will come up.

It will also come up if someone gets sensor data programmatically, via the API's GET /sensors endpoint, which also includes the entity address.

…s. Do warn.

Signed-off-by: Nicolas Höning <>
@nhoening nhoening linked an issue Jul 7, 2022 that may be closed by this pull request
Signed-off-by: Nicolas Höning <>
Copy link

coveralls commented Jul 7, 2022

Pull Request Test Coverage Report for Build 2632437510

  • 5 of 8 (62.5%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.01%) to 68.367%

Changes Missing Coverage Covered Lines Changed/Added Lines %
flexmeasures/data/models/ 4 7 57.14%
Totals Coverage Status
Change from base Build 2611878330: -0.01%
Covered Lines: 7095
Relevant Lines: 9843

💛 - Coveralls

@nhoening nhoening requested a review from Flix6x July 7, 2022 21:32
@nhoening nhoening added this to the 0.11.0 milestone Jul 7, 2022
@nhoening nhoening self-assigned this Jul 7, 2022
Copy link

@Flix6x Flix6x left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent. I also verified this resolves the issue when tunneling localhost.

@nhoening nhoening merged commit 16aa4bd into main Jul 8, 2022
@nhoening nhoening deleted the 456-asset-page-should-not-fail-if-entity-address-cant-be-constructed branch July 8, 2022 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

Asset page should not fail if entity address can't be constructed
3 participants