-
Notifications
You must be signed in to change notification settings - Fork 38
Get resampled data #458
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Get resampled data #458
Conversation
Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: F.N. Claessen <felix@seita.nl>
Pull Request Test Coverage Report for Build 2656017059
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks clean.
I have a general question about testing.
), | ||
], | ||
) | ||
def test_resolution_field_deserialization( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So here we're testing that timely beliefs changes the representation of the field.
Is there no need to use some data to test resolution adaptations? Do we already test that someplace else (testing the search
function?
I noticed that in the API level we are not testing GETting sensor data, just posting...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not timely-beliefs. This checks whether the given marshmallow schema in FlexMeasures parses these particular ISO durations as python timedeltas. I'd love to extend this with some nominal durations, but unfortunately timely-beliefs only works with absolute durations for now. I'll add this info to the test.
Low level tests for resampling data should happen in timely-beliefs imo.
Signed-off-by: F.N. Claessen <felix@seita.nl>
This PR introduces the "resolution" field to
/sensors/data
(GET) to obtain data in a given resolution.