Skip to content

Add replay button to sensor and asset pages #463

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 39 commits into from
Sep 8, 2022
Merged

Add replay button to sensor and asset pages #463

merged 39 commits into from
Sep 8, 2022

Conversation

Flix6x
Copy link
Contributor

@Flix6x Flix6x commented Jul 15, 2022 •
edited
Loading

Closes #436

  • Add replay button to sensor page
  • Add replay button to asset page
  • Get chart data including older beliefs
  • Loop through data replaying the past
  • Show simulation time underneath replay button
  • Speed up chart responsiveness: draw only the most recent beliefs in the chart
  • Speed up slicing: pop and append data
  • Speed up chart updating: remove only obsolete beliefs and insert only new beliefs [did not result in faster chart updating]

@Flix6x
Add replay button to sensor page
efd77e1 
Signed-off-by: F.N. Claessen <felix@seita.nl>
@Flix6x Flix6x added the UI label Jul 15, 2022
@Flix6x Flix6x self-assigned this Jul 15, 2022
@coveralls
Copy link
Collaborator

coveralls commented Jul 15, 2022 •
edited
Loading

Pull Request Test Coverage Report for Build 3015290146

  • 5 of 13 (38.46%) changed or added relevant lines in 3 files are covered.
  • 31 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-0.04%) to 65.056%
Changes Missing Coverage Covered Lines Changed/Added Lines %
flexmeasures/data/models/time_series.py 3 6 50.0%
flexmeasures/data/models/generic_assets.py 0 5 0.0%
Files with Coverage Reduction New Missed Lines %
flexmeasures/data/models/time_series.py 1 70.03%
flexmeasures/data/schemas/generic_assets.py 9 83.05%
flexmeasures/data/queries/utils.py 21 51.32%
Totals Coverage Status
Change from base Build 2999633885: -0.04%
Covered Lines: 6477
Relevant Lines: 9349
💛 - Coveralls

Flix6x added 2 commits July 16, 2022 14:48
@Flix6x
Add replay time below replay button
11f241d 
Signed-off-by: F.N. Claessen <felix@seita.nl>
@Flix6x
Include older beliefs in replay
cd8ce8e 
Signed-off-by: F.N. Claessen <felix@seita.nl>
@nhoening
Copy link
Contributor

I feel a pause button (next to Play) would be very useful to have!

@Flix6x
Show only most recent beliefs in replay at any given time, and add ne…
33b67a2 
…w slice to simulatedData instead of reslicing result all over

(also time function performance)

Signed-off-by: F.N. Claessen <felix@seita.nl>
@nhoening nhoening changed the title Add replay button to sensor page Add replay button to sensor and asset pages Jul 21, 2022
@Flix6x
Speed up: no need to resize
7d346a9 
Signed-off-by: F.N. Claessen <felix@seita.nl>
@Flix6x
Copy link
Contributor Author

Flix6x commented Jul 21, 2022

I feel a pause button (next to Play) would be very useful to have!

Did you notice the play button already animates into a pause button?

@nhoening
Copy link
Contributor

No, I did not!

@Flix6x
Copy link
Contributor Author

Flix6x commented Jul 21, 2022

Please note that the current code includes some helpful logging statements in your browser console: which functionality is being called when hitting the button, and some statements about execution time. I'll remove those timers at a later point.

When selecting a longer time periode (more than a week), the simulation slows down a bit. This seems to be mainly from reloading the data into the graph. Slicing the data takes 10-30 ms, and loading that data into the graph takes 30-200 ms, depending on how much data is shown in the graph. I tried different approaches here, but fell back to the original approach of telling vega to remove all previous data and to insert a completely new dataset at each iteration. Updating the view with removing only a few data points (representing obsolete beliefs) and inserting only a few data points (representing the most recent new beliefs) actually made it slower.

Flix6x and others added 16 commits August 8, 2022 20:25
@Flix6x
Make sure vega view is embedded in page before attempting to change i…
15cab01 
…ts dataset

Signed-off-by: F.N. Claessen <felix@seita.nl>
@Flix6x
Typo
3ed6847 
Signed-off-by: F.N. Claessen <felix@seita.nl>
@Flix6x
Add replay button to asset page
4697771 
Instead of having multiple columns with event_values, named by sensor_id, we switched to one column containing the sensor_id, in addition to the column holding the event_values.

Signed-off-by: F.N. Claessen <felix@seita.nl>
@Flix6x
Pass along sensor information as an object
e9cbcf4 
Signed-off-by: F.N. Claessen <felix@seita.nl>
@Flix6x
black
0cd4c2a 
Signed-off-by: F.N. Claessen <felix@seita.nl>
@Flix6x
missing type annotations
0333e21 
Signed-off-by: F.N. Claessen <felix@seita.nl>
@Flix6x
Nicer js formatting
366cd4f 
Signed-off-by: F.N. Claessen <felix@seita.nl>
@Flix6x
Remove obsolete code
ce6d5b1 
Signed-off-by: F.N. Claessen <felix@seita.nl>
@Flix6x
Refactor: move partition function into replay-utils.js
806b294 
Signed-off-by: F.N. Claessen <felix@seita.nl>
@Flix6x
Add dict representation of sensor to JSON representation of BeliefsDa…
92cf69e 
…taFrame and refactor: move updateBeliefs function into replay-utils.js

Signed-off-by: F.N. Claessen <felix@seita.nl>
@Flix6x
Merge branch 'main' into replay
96e889a
@Flix6x
Merge branch 'main' into replay
67c0403 
Signed-off-by: Felix Claessen <30658763+Flix6x@users.noreply.github.com>
@Flix6x
Remove duplicate swipe functionality on the sensor page (already cont…
d6be297 
…ained in leftsidepanel block)

Signed-off-by: F.N. Claessen <felix@seita.nl>
@Flix6x
Refactor: move sensor chart setup to base
715964a 
Signed-off-by: F.N. Claessen <felix@seita.nl>
@Flix6x
Refactor: simplify
36e6846 
Signed-off-by: F.N. Claessen <felix@seita.nl>
@Flix6x
Refactor: rename and simplify
96cdcf6 
Signed-off-by: F.N. Claessen <felix@seita.nl>
@Flix6x Flix6x added this to the 0.12.0 milestone Aug 12, 2022
@Flix6x Flix6x marked this pull request as ready for review August 12, 2022 11:28
@Flix6x Flix6x requested a review from nhoening August 12, 2022 11:29
nhoening
nhoening requested changes Sep 4, 2022
View reviewed changes
Copy link
Contributor

@nhoening nhoening left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work.

I concentrated on the JavaScript and have some ideas to improve readability.

But it does seem to work well, I tried it out locally.

Flix6x added 12 commits September 5, 2022 13:29
@Flix6x
Add inline comments
04c401a 
Signed-off-by: F.N. Claessen <felix@seita.nl>
@Flix6x
Add docstrings to replay-utils.js
3eea7bb 
Signed-off-by: F.N. Claessen <felix@seita.nl>
@Flix6x
Rename parameter
2e2bf00 
Signed-off-by: F.N. Claessen <felix@seita.nl>
@Flix6x
Remove obsolete variable
06891f2 
Signed-off-by: F.N. Claessen <felix@seita.nl>
@Flix6x
Rename simulation/playback to replay
4b5a540 
Signed-off-by: F.N. Claessen <felix@seita.nl>
@Flix6x
Rename function
8e7703f 
Signed-off-by: F.N. Claessen <felix@seita.nl>
@Flix6x
Pass beliefs data rather than fetch result to replay function
26df36b 
Signed-off-by: F.N. Claessen <felix@seita.nl>
@Flix6x
Add docstring to replay function
0c8bbe7 
Signed-off-by: F.N. Claessen <felix@seita.nl>
@Flix6x
Move beliefTimedelta to replay-utils.js
a7e411b 
Signed-off-by: F.N. Claessen <felix@seita.nl>
@Flix6x
Remove logging statements
8a0b88c 
Signed-off-by: F.N. Claessen <felix@seita.nl>
@Flix6x
Merge remote-tracking branch 'origin/main' into replay
d626855
@Flix6x
Changelog entry
299cf37 
Signed-off-by: F.N. Claessen <felix@seita.nl>
@Flix6x Flix6x requested a review from nhoening September 5, 2022 12:45
nhoening
nhoening approved these changes Sep 6, 2022
View reviewed changes
Copy link
Contributor

@nhoening nhoening left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it.
Just a few ideas to increase readability even more.

@nhoening
Copy link
Contributor

nhoening commented Sep 6, 2022

One more comment: I notice that a few lines in base.html do not have a semicolon:

220, 251, 259-261, 263, 265, 267-272, 308, 309, 311-319, etc.

I believe we should add them, or otherwise follow one formatting style.

@Flix6x
Add missing semicolons
89536e6 
Signed-off-by: F.N. Claessen <felix@seita.nl>
@Flix6x
Add inline comments
120de6d 
Signed-off-by: F.N. Claessen <felix@seita.nl>
@Flix6x
Remove obsolete commented out lines
266d2ae 
Signed-off-by: F.N. Claessen <felix@seita.nl>
@Flix6x
Expand docstring of partition function
99fe8de 
Signed-off-by: F.N. Claessen <felix@seita.nl>
@Flix6x Flix6x merged commit d491371 into main Sep 8, 2022
@Flix6x Flix6x deleted the replay branch September 8, 2022 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nhoening nhoening nhoening approved these changes

Assignees

@Flix6x Flix6x

Labels
UI
Projects
None yet
Milestone
0.12.0
Development

Successfully merging this pull request may close these issues.

Add option to replay what happened
3 participants
@Flix6x @coveralls @nhoening