Skip to content

Ability to provide a custom scheduling algorithm#505

Merged
nhoening merged 16 commits intomainfrom
Issue-9-custom-scheduler
Oct 16, 2022
Merged

Ability to provide a custom scheduling algorithm#505
nhoening merged 16 commits intomainfrom
Issue-9-custom-scheduler

Conversation

@nhoening
Copy link
Contributor

@nhoening nhoening commented Sep 21, 2022 •
edited
Loading

Fixes #9

@nhoening
First implementation of loading scheduler function from non-FM code
e3803b0 
Signed-off-by: Nicolas Höning <nicolas@seita.nl>
@nhoening
test loading of custom scheduler with dummy
2a7306f 
Signed-off-by: Nicolas Höning <nicolas@seita.nl>
@nhoening
changelog entry
e3707f1 
Signed-off-by: Nicolas Höning <nicolas@seita.nl>
@nhoening
complete the switch to default data source name for scheduling being …
1a3d0a1 
…'FlexMeasures'

Signed-off-by: Nicolas Höning <nicolas@seita.nl>
@nhoening
more complete dummy scheduler for testing
51586f3 
Signed-off-by: Nicolas Höning <nicolas@seita.nl>
@nhoening
allow a custom scheduler to be present in an importable package
bec8cf1 
Signed-off-by: Nicolas Höning <nicolas@seita.nl>
@nhoening
add documentation
7ae7715 
Signed-off-by: Nicolas Höning <nicolas@seita.nl>
@nhoening
one more data source renaming in tests
e9574a8 
Signed-off-by: Nicolas Höning <nicolas@seita.nl>
@nhoening
save custom data source name on job, so it can be looked up in get_sc…
19d5d51 
…hedule endpoint

Signed-off-by: Nicolas Höning <nicolas@seita.nl>
@nhoening nhoening added this to the 0.12.0 milestone Sep 21, 2022
@nhoening
one more data source renaming in tests
2ddd7cc 
Signed-off-by: Nicolas Höning <nicolas@seita.nl>
@coveralls
Copy link
Collaborator

coveralls commented Sep 21, 2022 •
edited
Loading

Pull Request Test Coverage Report for Build 3256248183

  • 36 of 43 (83.72%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.05%) to 65.017%
Changes Missing Coverage Covered Lines Changed/Added Lines %
flexmeasures/api/v3_0/sensors.py 1 2 50.0%
flexmeasures/data/services/scheduling.py 35 41 85.37%
Totals Coverage Status
Change from base Build 3243560162: 0.05%
Covered Lines: 6511
Relevant Lines: 9402
💛 - Coveralls

@nhoening
move back from renaming default script data source - we made issue #508…
ed45916 
… to work on this specifically

Signed-off-by: Nicolas Höning <nicolas@seita.nl>
@nhoening
forgot one more data source renaming
08bd6cc 
Signed-off-by: Nicolas Höning <nicolas@seita.nl>
@nhoening nhoening requested a review from Flix6x September 21, 2022 20:48
Flix6x
Flix6x reviewed Oct 9, 2022
View reviewed changes
Flix6x
Flix6x approved these changes Oct 9, 2022
View reviewed changes
Copy link
Contributor

@Flix6x Flix6x left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, given that my only comments are minor.

@nhoening
implement review comments
4e90a0e 
Signed-off-by: Nicolas Höning <nicolas@seita.nl>
@nhoening
Merge branch 'main' into Issue-9-custom-scheduler
045bde8 
Signed-off-by: Nicolas Höning <nicolas@seita.nl>
@nhoening
we cannot use inclusive yet, while we require/support Pandas 1.25
6c1301b 
Signed-off-by: Nicolas Höning <nicolas@seita.nl>
@nhoening
Merge branch 'Issue-9-custom-scheduler' of github.com:FlexMeasures/fl…
fb11b77 
…exmeasures into Issue-9-custom-scheduler
@nhoening nhoening merged commit feb3d33 into main Oct 16, 2022
@nhoening nhoening deleted the Issue-9-custom-scheduler branch October 16, 2022 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Flix6x Flix6x Flix6x approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

0.12.0

Development

Successfully merging this pull request may close these issues.

Using custom scheduling algorithms

3 participants

@nhoening @coveralls @Flix6x

Comments