Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keyboard replay control #562

Merged
merged 14 commits into from Jan 27, 2023
Merged

Keyboard replay control #562

merged 14 commits into from Jan 27, 2023

Conversation

Flix6x
Copy link
Contributor

@Flix6x Flix6x commented Dec 22, 2022

A bit of refactoring along with the introduction of keyboard control of replay (p to play/pause/resume and s to stop).

Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: F.N. Claessen <felix@seita.nl>
@coveralls
Copy link
Collaborator

coveralls commented Dec 22, 2022

Pull Request Test Coverage Report for Build 4023704172

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 65.362%

Totals Coverage Status
Change from base Build 3943281056: 0.0%
Covered Lines: 6847
Relevant Lines: 9835

💛 - Coveralls

Signed-off-by: F.N. Claessen <felix@seita.nl>
…re resolving promises

Signed-off-by: F.N. Claessen <felix@seita.nl>
@Flix6x Flix6x marked this pull request as ready for review December 23, 2022 12:17
@Flix6x Flix6x requested a review from nhoening December 23, 2022 12:18
@Flix6x Flix6x added this to the 0.13.0 milestone Jan 3, 2023
Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: F.N. Claessen <felix@seita.nl>
# Conflicts:
#	documentation/changelog.rst
@Flix6x
Copy link
Contributor Author

Flix6x commented Jan 17, 2023

@nhoening Great for demos...

Copy link
Contributor

@nhoening nhoening left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works well. I only had one question about that new function.

signal?.addEventListener( "abort", handleAbort );
var internalTimer = setTimeout(internalCallback, delayInMilliseconds);

function internalCallback() {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm a bit confused: Should these two functions not be declared before they are used in the event listener?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

# Conflicts:
#	documentation/changelog.rst
@Flix6x Flix6x merged commit a1fb871 into main Jan 27, 2023
5 checks passed
@Flix6x Flix6x deleted the keyboard-replay-actions branch January 27, 2023 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants