Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 588: CLI command add schedule for-storage not working without --as-job #589

Merged

Conversation

nhoening
Copy link
Contributor

@nhoening nhoening commented Feb 4, 2023

Fixes #588

This only affects usage without --as-job

…(which affects all sensors) if we have no sensor_id

Signed-off-by: Nicolas Höning <nicolas@seita.nl>
Signed-off-by: Nicolas Höning <nicolas@seita.nl>
@nhoening nhoening linked an issue Feb 4, 2023 that may be closed by this pull request
@nhoening nhoening requested a review from Flix6x February 4, 2023 11:38
@coveralls
Copy link
Collaborator

coveralls commented Feb 4, 2023

Pull Request Test Coverage Report for Build 4091774821

  • 0 of 2 (0.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 65.362%

Changes Missing Coverage Covered Lines Changed/Added Lines %
flexmeasures/cli/data_add.py 0 2 0.0%
Totals Coverage Status
Change from base Build 4023710242: 0.0%
Covered Lines: 6847
Relevant Lines: 9835

💛 - Coveralls

Signed-off-by: Nicolas Höning <nicolas@seita.nl>
@nhoening nhoening added this to the 0.12.2 milestone Feb 4, 2023
@nhoening nhoening merged commit 7451d10 into main Feb 4, 2023
5 checks passed
@nhoening nhoening deleted the 588-cli-add-schedule-for-storage-not-working-in-toy-example branch February 4, 2023 13:28
Flix6x pushed a commit that referenced this pull request Feb 4, 2023
…ing without --as-job (#589)

* when deleting prognoses, only delete forecasting and scheduling jobs (which affects all sensors) if we have no sensor_id

Signed-off-by: Nicolas Höning <nicolas@seita.nl>

* Fix parameters for make_schedule in add schedule for-storage CLI command

Signed-off-by: Nicolas Höning <nicolas@seita.nl>

* add a docstring

Signed-off-by: Nicolas Höning <nicolas@seita.nl>

---------

Signed-off-by: Nicolas Höning <nicolas@seita.nl>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working CLI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cli add schedule for-storage not working in toy example
3 participants