Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert some modern type annotations, to keep support for Python 3.8 #694

Merged
merged 1 commit into from
May 22, 2023

Conversation

Flix6x
Copy link
Contributor

@Flix6x Flix6x commented May 22, 2023

Closes #684.

Signed-off-by: F.N. Claessen <felix@seita.nl>
@Flix6x Flix6x added the bug Something isn't working label May 22, 2023
@Flix6x Flix6x added this to the 0.14.0 milestone May 22, 2023
@Flix6x Flix6x requested a review from nhoening May 22, 2023 14:52
@Flix6x Flix6x self-assigned this May 22, 2023
@Flix6x Flix6x changed the title Revert some modern type annotations for supporting Python 3.8 Revert some modern type annotations, to keep support for Python 3.8 May 22, 2023
Copy link
Contributor

@nhoening nhoening left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Flix6x Flix6x merged commit 877991f into main May 22, 2023
5 checks passed
@Flix6x Flix6x deleted the type-annotations-compatible-with-python-3.8 branch May 22, 2023 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Revert type annotation updates incompatible with Python3.8
2 participants