feature: show a warning message whenever a heatmap is shown that masks sources #780
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s sources Signed-off-by: F.N. Claessen <felix@seita.nl>
nhoening
approved these changes
Aug 1, 2023
Flix6x
added a commit
that referenced
this pull request
Aug 3, 2023
This is essentially a heatmap of the sensor's values, with dates on the y-axis and time of day on the x-axis. For individual devices, it gives an insight into the device's running times. A new button lets users switch between charts. * Introduce new sensor chart type Signed-off-by: F.N. Claessen <felix@seita.nl> * Fix alignment of y-axis labels Signed-off-by: F.N. Claessen <felix@seita.nl> * Add button to switch between sensor chart types Signed-off-by: F.N. Claessen <felix@seita.nl> * Streamline button title with others Signed-off-by: F.N. Claessen <felix@seita.nl> * Improve alignment of first and last time-of-day labels Signed-off-by: F.N. Claessen <felix@seita.nl> * Cleaner solution to prevent showing next date outside selected daterange Signed-off-by: F.N. Claessen <felix@seita.nl> * refactor: field definitions Signed-off-by: F.N. Claessen <felix@seita.nl> * remove obsolete line Signed-off-by: F.N. Claessen <felix@seita.nl> * fix: replay ruler for new chart type Signed-off-by: F.N. Claessen <felix@seita.nl> * black Signed-off-by: F.N. Claessen <felix@seita.nl> * feat: remember selected chart type within session Signed-off-by: F.N. Claessen <felix@seita.nl> * refactor: move towards a single function to set session variables from request variables Signed-off-by: F.N. Claessen <felix@seita.nl> * refactor: move template variables Signed-off-by: F.N. Claessen <felix@seita.nl> * only store non-None session variables Signed-off-by: F.N. Claessen <felix@seita.nl> * docs: changelog entry Signed-off-by: F.N. Claessen <felix@seita.nl> * flake8 Signed-off-by: F.N. Claessen <felix@seita.nl> * feat: top y-coordinate of ruler moves with belief time, too Signed-off-by: F.N. Claessen <felix@seita.nl> * rename matrix chart to heatmap Signed-off-by: F.N. Claessen <felix@seita.nl> * feat: heatmap shows only data from a single source Signed-off-by: F.N. Claessen <felix@seita.nl> * feat: selected source is the one with the most visible data Signed-off-by: F.N. Claessen <felix@seita.nl> * docs: add name of new chart type to changelog entry Signed-off-by: F.N. Claessen <felix@seita.nl> * fix: in case of a tied rank, where multiple sources have exactly the same number of data points, arbitrarily pick the first one in the data Signed-off-by: F.N. Claessen <felix@seita.nl> * feature: show a warning message whenever a heatmap is shown that masks sources (#780) Signed-off-by: F.N. Claessen <felix@seita.nl> --------- Signed-off-by: F.N. Claessen <felix@seita.nl>
Flix6x
added a commit
that referenced
this pull request
Aug 3, 2023
This PR masks overlapping data during a DST transition (commonly on 1 day during fall) and then shows it split up vertically in a separate layer. * Introduce new sensor chart type Signed-off-by: F.N. Claessen <felix@seita.nl> * Fix alignment of y-axis labels Signed-off-by: F.N. Claessen <felix@seita.nl> * Add button to switch between sensor chart types Signed-off-by: F.N. Claessen <felix@seita.nl> * Streamline button title with others Signed-off-by: F.N. Claessen <felix@seita.nl> * Improve alignment of first and last time-of-day labels Signed-off-by: F.N. Claessen <felix@seita.nl> * Cleaner solution to prevent showing next date outside selected daterange Signed-off-by: F.N. Claessen <felix@seita.nl> * refactor: field definitions Signed-off-by: F.N. Claessen <felix@seita.nl> * remove obsolete line Signed-off-by: F.N. Claessen <felix@seita.nl> * fix: replay ruler for new chart type Signed-off-by: F.N. Claessen <felix@seita.nl> * black Signed-off-by: F.N. Claessen <felix@seita.nl> * fix: separate overlapping data during the fall DST transition Signed-off-by: F.N. Claessen <felix@seita.nl> * refactor: reuse code Signed-off-by: F.N. Claessen <felix@seita.nl> * fix: tooltip Signed-off-by: F.N. Claessen <felix@seita.nl> * fix: mind the gap Signed-off-by: F.N. Claessen <felix@seita.nl> * add: warn users when viewing sensor data that includes a DST transition Signed-off-by: F.N. Claessen <felix@seita.nl> * add: also warn users when viewing asset data that includes a DST transition Signed-off-by: F.N. Claessen <felix@seita.nl> * add: UI styling Signed-off-by: F.N. Claessen <felix@seita.nl> * add: add timezone to tooltip during fall DST transition Signed-off-by: F.N. Claessen <felix@seita.nl> * style: black Signed-off-by: F.N. Claessen <felix@seita.nl> * feat: remember selected chart type within session Signed-off-by: F.N. Claessen <felix@seita.nl> * refactor: move towards a single function to set session variables from request variables Signed-off-by: F.N. Claessen <felix@seita.nl> * refactor: move template variables Signed-off-by: F.N. Claessen <felix@seita.nl> * only store non-None session variables Signed-off-by: F.N. Claessen <felix@seita.nl> * docs: changelog entry Signed-off-by: F.N. Claessen <felix@seita.nl> * flake8 Signed-off-by: F.N. Claessen <felix@seita.nl> * feat: top y-coordinate of ruler moves with belief time, too Signed-off-by: F.N. Claessen <felix@seita.nl> * rename matrix chart to heatmap Signed-off-by: F.N. Claessen <felix@seita.nl> * feat: heatmap shows only data from a single source Signed-off-by: F.N. Claessen <felix@seita.nl> * feat: selected source is the one with the most visible data Signed-off-by: F.N. Claessen <felix@seita.nl> * docs: add name of new chart type to changelog entry Signed-off-by: F.N. Claessen <felix@seita.nl> * fix: workaround for vega/vega-lite#6544 Signed-off-by: F.N. Claessen <felix@seita.nl> * docs: changelog entry Signed-off-by: F.N. Claessen <felix@seita.nl> * fix: in case of a tied rank, where multiple sources have exactly the same number of data points, arbitrarily pick the first one in the data Signed-off-by: F.N. Claessen <felix@seita.nl> * feature: show a warning message whenever a heatmap is shown that masks sources (#780) Signed-off-by: F.N. Claessen <felix@seita.nl> --------- Signed-off-by: F.N. Claessen <felix@seita.nl>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I made this a separate PR for your reviewing convenience.
Look and feel