Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

less conservative value for the big-M value #905

Merged
merged 6 commits into from Nov 27, 2023
Merged

less conservative value for the big-M value #905

merged 6 commits into from Nov 27, 2023

Conversation

victorgarcia98
Copy link
Contributor

@victorgarcia98 victorgarcia98 commented Nov 21, 2023 •
edited

TODO

  • Exclude, efficiency and maybe stock max/min.
  • Add test case with inflexible devices with capacities that exceed those of the storage.

Related Items

#770

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on code under GPL or other license that is incompatible with FlexMeasures

@victorgarcia98
less conservative value for the big-M value
c25d5c1 
Signed-off-by: Victor Garcia Reolid <victor@seita.nl>
@victorgarcia98 victorgarcia98 self-assigned this Nov 21, 2023
@Flix6x Flix6x added Still Needs Manual Backport bug Something isn't working labels Nov 21, 2023
Flix6x
Flix6x reviewed Nov 21, 2023
View reviewed changes
Copy link
Contributor

@Flix6x Flix6x left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great find! Good solution, and I agree with the todos.

@victorgarcia98
add comment (also to try codecoverage)
ca883a6 
Signed-off-by: Victor Garcia Reolid <victor@seita.nl>
@victorgarcia98
add test
b645d83 
Signed-off-by: Victor Garcia Reolid <victor@seita.nl>
@victorgarcia98
Merge remote-tracking branch 'origin/main' into hotfix/planning/big-M…
e9ac31a 
…-estimation

Signed-off-by: Victor Garcia Reolid <victor@seita.nl>
Flix6x
Flix6x approved these changes Nov 22, 2023
View reviewed changes
Copy link
Contributor

@Flix6x Flix6x left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you assign the changelog entry to 0.17.1?

@victorgarcia98
add changelog
34110f7 
Signed-off-by: Victor Garcia Reolid <victor@seita.nl>
Flix6x
Flix6x approved these changes Nov 22, 2023
View reviewed changes
Copy link
Contributor

@Flix6x Flix6x left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@victorgarcia98 victorgarcia98 marked this pull request as ready for review November 23, 2023 08:12
@victorgarcia98 victorgarcia98 merged commit 99c1e5f into main Nov 27, 2023
9 checks passed
@victorgarcia98 victorgarcia98 deleted the hotfix/planning/big-M-estimation branch November 27, 2023 07:59
Flix6x pushed a commit that referenced this pull request Dec 7, 2023
@victorgarcia98 @Flix6x
less conservative value for the big-M value (#905)
d498d01 
* less conservative value for the big-M value

Signed-off-by: Victor Garcia Reolid <victor@seita.nl>

* add comment (also to try codecoverage)

Signed-off-by: Victor Garcia Reolid <victor@seita.nl>

* add test

Signed-off-by: Victor Garcia Reolid <victor@seita.nl>

* add changelog

Signed-off-by: Victor Garcia Reolid <victor@seita.nl>

---------

Signed-off-by: Victor Garcia Reolid <victor@seita.nl>
@Flix6x Flix6x added this to the 0.17.1 milestone Dec 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Flix6x Flix6x Flix6x approved these changes

Assignees

@victorgarcia98 victorgarcia98

Labels
bug Something isn't working Scheduling
Projects
None yet
Milestone
0.17.1
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@victorgarcia98 @Flix6x