fix: 'str' object has no attribute 'removesuffix' in Python 3.8 #950
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ahmad Wahid <ahmedwahid16101@gmail.com>
Signed-off-by: Ahmad Wahid <ahmedwahid16101@gmail.com>
…dpoint-does-not-work-under-py38-1
Signed-off-by: F.N. Claessen <felix@seita.nl>
Flix6x
approved these changes
Jan 8, 2024
Flix6x
deleted the
942-apiv3_0-public-endpoint-does-not-work-under-py38-1
branch
Flix6x
added a commit
that referenced
this pull request
Jan 12, 2024
…n Python 3.8 (#950) * fix suffix api issue Signed-off-by: Ahmad Wahid <ahmedwahid16101@gmail.com> * update changelog Signed-off-by: Ahmad Wahid <ahmedwahid16101@gmail.com> * docs: move changelog entry to 0.18.1 Signed-off-by: F.N. Claessen <felix@seita.nl> --------- Signed-off-by: Ahmad Wahid <ahmedwahid16101@gmail.com> Signed-off-by: F.N. Claessen <felix@seita.nl> Co-authored-by: F.N. Claessen <felix@seita.nl>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduced a custom
removesuffixfunction for removing a suffix from the URL, catering to Python 3.8 users sincetext.removesuffixis not a built-in feature in Python 3.8. Consider deprecating this function after discontinuing support for Python 3.8.